444940 - Unofficial-branded builds will prompt to set default client when installed (/updated) from a previously branded Thunderbird version.

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Mark Banner (:standard8)]

per bug 397621, we'll be unnecessarily prompting for a default client "change" if someone installs Shredder in the same directory as a previously branded Thunderbird (e.g. 3.0a1 to 3.0a2...):

bug 397621 comment #31:
> This does cause one problem in that the Registry Key name under
> HKLM\Software\Clients\Mail typically shouldn't change for nightly or release
> builds.
> 
> http://mxr.mozilla.org/mozilla/source/mail/installer/windows/nsis/shared.nsh#87
> 
> Another option would be to clean up these keys when installing a nightly into a
> directory that previously was a release build and vice versa but that would
> cause the user to be prompted to set the app as default when the previous
> installation was already default.
> 
> Perhaps this will be taken care of elsewhere but the
> HKLM\Software\Clients\Mail\Shredder\Capabilities ApplicationName is still
> Thunderbird

I think these can be fixed reasonably simply. Not sure if we should block shredder 3.0a2 on it though.

Probably not a big issue, but if we don't change it before hand, then would we have/want to add in extra code to remove the extra items that we incorrectly added?

Comment 1

[Robert Strong (they/them - no direct email)]

I'm working on a fairly major patch to the installer in Bug 404609 and would like to include the fix for this in that patch if it is ok with everyone. As for removing the incorrect entries added that should be fairly trivial as well as long as we go with the first option as Firefox does.

Comment 2

[Robert Strong (they/them - no direct email)]

I've added the fix for this to the patch in Bug 404609.

Comment 3

[Mark Banner (:standard8)]

Reassign bug to rob as he's working on this in bug 404609.

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed by the checkin of bug 404609.