Closed Bug 445039 Opened 11 years ago Closed 11 years ago

Only package oji.xpt if it's likely to be there

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla3.1a2

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch FixSplinter Review
While we wait for bug 442399 to put LiveConnect out of its misery entirely, we're spewing "Possible missing or unnecessary..." errors in the build logs, trying to package oji.xpt whether or not MOZ_OJI is defined.
Attachment #329336 - Flags: review?(gavin.sharp)
oji.xpt isn't there despite http://mxr.mozilla.org/mozilla/source/modules/oji/Makefile.in#47 making it look like it would be because http://mxr.mozilla.org/mozilla/source/modules/Makefile.in#72 doesn't let you get that far without MOZ_OJI. That's bogus, but there's a limit to how much fiddling with corpses I'm willing to do.
Attachment #329336 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → philringnalda
http://hg.mozilla.org/mozilla-central/index.cgi/rev/4e27fb8bb3e5
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 3.1a2 → mozilla3.1a2
You need to log in before you can comment on or make changes to this bug.