Closed Bug 442399 Opened 13 years ago Closed 12 years ago

remove LiveConnect from the tree

Categories

(Core Graveyard :: Java: Live Connect, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: jst, Assigned: jst)

References

Details

Attachments

(2 files)

Once the new Java plugin is more readily available (on all major platforms etc), OJI and LiveConnect needs to go away. Loads of unmaintained code full or complexity and problems we no longer want or need with the new NPRuntime enabled Java plugin.

This is a tracking bug to track the removal of this code. Make other related and more specific bugs block this tracking bug.
Version: unspecified → Trunk
Also see http://wiki.mozilla.org/Mozilla_2/Kill_LiveConnect for more information.
Version: Trunk → unspecified
Depends on: 444963
Depends on: 445039
Version: unspecified → Trunk
Flags: wanted1.9.1?
We can't do this for 1.9.1 as there's no Java plugin for the Mac available yet that doesn't depend on this. The current target is the release following 1.9.1.
Flags: wanted1.9.1? → wanted1.9.1-
Removing LiveConnect will also break firefox extensions that use it (e.g. PiggyBank). Extension developers that require java will be left with http://pcscholl.de/2007/08/23/java-applets-in-xul (pretty ugly, heh?) alone.
The intent is that the new NPRuntime Java Plug-In in Java SE 6 Update 10 will provide the facilities to allow current Firefox extensions using Java to continue to work. Support is present in Firefox 3 and the new Java Plug-In for the window-scope "java" and "Packages" keywords. However, it appears there are issues that still need to be solved where it was previously assumed that LiveConnect calls coming from Firefox extensions had additional privileges, and we currently don't have a mechanism in the new Java Plug-In for granting such privileges to Firefox extensions. It isn't clear to me that simply granting all permissions to calls coming from a chrome:// document is the best solution, though it may be.
Assignee: jst → joshmoz
Making this bug about LiveConnect, opening a new bug about OJI.
Summary: Remove LiveConnect/OJI from the tree. → remove LiveConnect from the tree
OJI removal is bug 485984.
Flags: wanted1.9.2+
Assignee: joshmoz → jst
No longer blocks: Win16Removal
So... the landing for bug 485984 incidentally turned off building of LiveConnect.
I can't say I intended to do that but it seems like we should just leave it unless we have a specific reason to re-enable it. We should disable xpcom plugin loading and remove LiveConnect from the tree altogether very soon.
How to use java from FF extensions then? Is there a way you can confirm that works?
With Java SE 6 Update 12 and later (already shipping) we have confirmed that extensions like FireGoose which use Java are working with the new NPRuntime Java Plug-In. Slight syntactic changes may be needed to JavaScript code which accesses Java for a few constructs which are no longer supported.
This is the whole deal (gzip'ed as it's over 2Mb), removals n' all. I'll attach a patch that only lists the directories removed and shows the changes to the code separately in a bit.
Attached patch Source changes.Splinter Review
This is the changes to the tree to remove liveconnect, not including the removal of the directories as that makes the patch too big for bugzilla. In addition to these changes, the following directories will be removed:

  js/src/liveconnect/
  js/tests/lc2/
  js/tests/lc3/
  js/tests/src/
Attachment #385454 - Flags: superreview?(brendan)
Attachment #385454 - Flags: review?(joshmoz)
Attachment #385454 - Flags: review?(bclary)
Attachment #385454 - Flags: review?(joshmoz) → review+
Does removed-files.in need to be updated as well?
Yes! I didn't know about that, to be honest, but yes, we need to add a line containing:

@DLL_PREFIX@jsj@DLL_SUFFIX@

to that file and any liveconnect libraries laying around will get deleted. Even better! Thanks!
Attachment #385454 - Flags: review?(bclary) → review+
Comment on attachment 385454 [details] [diff] [review]
Source changes.

...

>diff -r ac3c29f427bf js/tests/README-jsDriver.html
>--- a/js/tests/README-jsDriver.html	Fri Jun 26 08:20:31 2009 -0700
>+++ b/js/tests/README-jsDriver.html	Fri Jun 26 09:03:01 2009 -0700

...

>@@ -315,26 +305,18 @@
>         <br>
>       <dt><b>EXAMPLES</b></dt>
>       <dd>
>-          <code>perl jsDriver.pl -e smdebug -L lc*</code><br>
>-          Executes all tests EXCEPT the liveconnect tests against the
>+	XXX
why the XXX?

>+          <code>perl jsDriver.pl -e smdebug -L ecma3*</code><br>

ecma_3

>+          Executes all tests EXCEPT the ecma3 tests against the

ecma_3

>           SpiderMonkey debug shell, writing the results
>           to the default result file.  (NOTE: Unix shells take care of wildcard
>-          expansion, turning <code>lc*</code> into <code>lc2 lc3</code>.  Under
>-          a DOS shell, you must explicitly list the directories.)
>+          expansion, turning <code>ecma3*</code> into

ecma_3

>+	  <code>ecma3 ecma3_1</code>.  Under a DOS shell, you must explicitly

ecma_3 ecma_3_1

In the full patch, you need to remove browser.js in the lc{2,3} (sub)directories

r+ with those nits.
Comment on attachment 385454 [details] [diff] [review]
Source changes.

Yay!

/be
Attachment #385454 - Flags: superreview?(brendan) → superreview+
I fixed the things that Bob pointed out in the patch and committed this. R.I.P. LiveConnect.

http://hg.mozilla.org/mozilla-central/rev/516dfcdf9a57
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.