445181 - Firefox upgrades don't check for remote extension compatibility

Status: VERIFIED DUPLICATE of bug 324121

(Toolkit :: Add-ons Manager, defect)

Description

[Clare Bayley]

When Firefox attempts to update and makes an extension compatability check, it only checks the local version information. It should check to see if a remote update or new remote version information is available that will make the extension compatible with the version of Firefox being installed.

Comment 1

[Dave Townsend [:mossop]]

Which point in the upgrade process are you talking about? That no remote check is performed when manually checking for app updates is already filed as bug 434155.

Comment 2

[Clare Bayley]

Darn, missed that one. This one is for both manual 'Check for Updates' checks and for automatic background checks. Could probably just use 434155 though.

Comment 3

[Dave Townsend [:mossop]]

Bug 434465 has a small note about the background update check failing, but by all means take care of them both in one go!

Comment 4

[Clare Bayley]

Should I do that here then, for full disclosure of the problem?... ::still not sure how this whole bugzilla thing works:: I've almost got a patch ready to submit.

Comment 5

[Clare Bayley]

Attachment: New UpdateWithSpecifiedVersion function for checking remote extension compatability: WIP

Implemented new UpdateWithSpecifiedVersion function that takes in the version of the app and platform that are being updated to, and uses them for ui compatability checks instead of the current app/platform version. It also takes a boolean so it doesn't modify remote information.

The old update function hasn't changed - it just passes in false and null for the above information, which the ChekcForUpdates function catches and replaces with the default values.

Comment 6

[Clare Bayley]

Comment on attachment 329500 [details] [diff] [review]
New UpdateWithSpecifiedVersion function for checking remote extension compatability: WIP

still a wip.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug is in the features list for Firefox 3.1. Asking for blocking.

Comment 8

[Robert Strong (they/them - no direct email)]

Though the UI is part of App Update this needs to be provided by an interface
of the Add-ons Manager code so moving over there where the actual work needs to
be done.

Comment 9

[Robert Strong (they/them - no direct email)]

This is the same as bug 324121 which has been around longer so marking dupe. I have Clare's WIP patches and will be adding them over there.