445429 - <helpSecurityOverlay.xul> uses removed |delete*CertFlag|

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

1. Select a certificate.
2. Press "Delete" button.
3. Press "Help" in the delete dialog.
3r.
{{
Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://communicator/content/helpSecurityOverlay.xul :: doDeleteCertificateHelpButton :: line 69"  data: no]
Source File: chrome://communicator/content/helpSecurityOverlay.xul
Line: 69
}}

Bug 344243 (still) used the 4 |deleteUser*Flag|,
which bug 348259 had (already) removed :-<

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Bug 344243 (still) used the 4 |deleteUser*Flag|,

s/deleteUser*Flag/delete*CertFlag/ !

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <helpSecurityOverlay.xul>

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Use tab names directly, here too.

Comment 3

[[e-mail]]

Comment on attachment 329768 [details] [diff] [review]
(Av1) <helpSecurityOverlay.xul>

(In reply to comment #0)
> Bug 344243 (still) used the 4 |deleteUser*Flag|,
> which bug 348259 had (already) removed :-<
Actually the code was originally written for bug 343395 which predates 348259 thus technically making that a regression.

Comment 4

[Stefan [:stefanh]]

http://hg.mozilla.org/index.cgi/comm-central/rev/a8b667418902

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008072716 SeaMonkey/2.0a1pre] (home made) (W2Ksp4)

V.Fixed