Closed Bug 445429 Opened 12 years ago Closed 12 years ago

<helpSecurityOverlay.xul> uses removed |delete*CertFlag|

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.0a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

1. Select a certificate.
2. Press "Delete" button.
3. Press "Help" in the delete dialog.
3r.
{{
Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://communicator/content/helpSecurityOverlay.xul :: doDeleteCertificateHelpButton :: line 69"  data: no]
Source File: chrome://communicator/content/helpSecurityOverlay.xul
Line: 69
}}

Bug 344243 (still) used the 4 |deleteUser*Flag|,
which bug 348259 had (already) removed :-<
(In reply to comment #0)
> Bug 344243 (still) used the 4 |deleteUser*Flag|,

s/deleteUser*Flag/delete*CertFlag/ !
Summary: <helpSecurityOverlay.xul> uses removed |deleteUser*Flag| → <helpSecurityOverlay.xul> uses removed |delete*CertFlag|
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Use tab names directly, here too.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #329768 - Flags: superreview?(neil)
Attachment #329768 - Flags: review?(neil)
Component: Security → Help
Flags: in-litmus-
QA Contact: seamonkey → danielwang
Target Milestone: --- → seamonkey2.0alpha
Comment on attachment 329768 [details] [diff] [review]
(Av1) <helpSecurityOverlay.xul>

(In reply to comment #0)
> Bug 344243 (still) used the 4 |deleteUser*Flag|,
> which bug 348259 had (already) removed :-<
Actually the code was originally written for bug 343395 which predates 348259 thus technically making that a regression.
Attachment #329768 - Flags: superreview?(neil)
Attachment #329768 - Flags: superreview+
Attachment #329768 - Flags: review?(neil)
Attachment #329768 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/index.cgi/comm-central/rev/a8b667418902
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008072716 SeaMonkey/2.0a1pre] (home made) (W2Ksp4)

V.Fixed
Status: RESOLVED → VERIFIED
Flags: in-litmus- → in-testsuite-
You need to log in before you can comment on or make changes to this bug.