Closed Bug 445387 Opened 13 years ago Closed 13 years ago

In </suite/*>, "use a xul <stringbundle/> instead of including the strres.js code"

Categories

(SeaMonkey :: General, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(6 files, 3 obsolete files)

"Found 15 matching lines in 12 files"

minus the 2 <pref-languages*.xul> ready for checkin in bug 56680.

***

<pageInfo.xul> should be (kept in) sync' with the one from (FF) bug 445374.
Depends on: 445429
Depends on: 445438
Depends on: 445467
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
Assignee: general → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #329904 - Flags: review?(iann_bugzilla)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
Attachment #329942 - Flags: review?(db48x)
Comment on attachment 329942 [details] [diff] [review]
(Bv1) </suite/browser/pageinfo/*>
[Checkin: Comment 13]

looks good, r=db48x
Attachment #329942 - Flags: review?(db48x) → review+
Flags: in-litmus-
Keywords: checkin-needed
Whiteboard: [c-n: Bv1 // Leave opened]
Target Milestone: --- → seamonkey2.0alpha
Attached patch (Cv1) <urlbarBindings.xml> (obsolete) — Splinter Review
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

It used the <strres.js> from (shared) <utilityOverlay.xul>,
which I'll submit a later/separate patch for.
Attachment #330022 - Flags: review?(db48x)
Depends on: 445753
Depends on: 445790
Depends on: 445807
Av1, using |getStringBundle()| from Toolkit <contentAreaUtils.js> ;-)
Attachment #329904 - Attachment is obsolete: true
Attachment #330080 - Flags: review?(iann_bugzilla)
Attachment #329904 - Flags: review?(iann_bugzilla)
Av1a, with s/Toolkit//, as SeaMonkey uses its forked file :-|
Attachment #330080 - Attachment is obsolete: true
Attachment #330082 - Flags: review?(iann_bugzilla)
Attachment #330080 - Flags: review?(iann_bugzilla)
Attachment #330082 - Flags: review?(iann_bugzilla) → review+
Whiteboard: [c-n: Bv1 // Leave opened] → [c-n: Av1b, Bv1 // Leave opened]
2 useless includes, as all (function) callers have been fixed in other patches.
Attachment #330160 - Flags: superreview?(jag)
Attachment #330160 - Flags: review?(jag)
2 useless includes, as all (function) callers have been fixed in other patches.
Attachment #330161 - Flags: review?(db48x)
Comment on attachment 330161 [details] [diff] [review]
(Ev1) </suite/common/bookmarks/*.xul> 
[Checkin: Comment 15]

would have liked to see this all as one patch, but it's ok. r=db48x
Attachment #330161 - Flags: review?(db48x) → review+
Whiteboard: [c-n: Av1b, Bv1 // Leave opened] → [c-n: Av1b, Bv1, Ev1 // Leave opened]
Comment on attachment 330022 [details] [diff] [review]
(Cv1) <urlbarBindings.xml>

the searchValue setter could be simplified to use fewer variables, but it's no matter. r=db48x
Attachment #330022 - Flags: review?(db48x) → review+
Cv1, with comment 10 suggestion(s).
Attachment #330022 - Attachment is obsolete: true
Attachment #330751 - Flags: review?(db48x)
Attachment #330751 - Flags: review?(db48x) → review+
Whiteboard: [c-n: Av1b, Bv1, Ev1 // Leave opened] → [c-n: Av1b, Bv1, Cv1a, Ev1 // Leave opened]
Serge, you still need sr on Av1b, Bv1, Cv1a, Ev1
Keywords: checkin-needed
Comment on attachment 329942 [details] [diff] [review]
(Bv1) </suite/browser/pageinfo/*>
[Checkin: Comment 13]

http://hg.mozilla.org/comm-central/index.cgi/rev/b247c1a31380
Attachment #329942 - Attachment description: (Bv1) </suite/browser/pageinfo/*> → (Bv1) </suite/browser/pageinfo/*> (Checked in)
Comment on attachment 330082 [details] [diff] [review]
(Av1b) </suite/common/permissions/*.xul> 
[Checkin: Comment 14]

http://hg.mozilla.org/comm-central/index.cgi/rev/dd2b64479966
Attachment #330082 - Attachment description: (Av1b) </suite/common/permissions/*.xul> → (Av1b) </suite/common/permissions/*.xul> (Checked in)
Comment on attachment 330161 [details] [diff] [review]
(Ev1) </suite/common/bookmarks/*.xul> 
[Checkin: Comment 15]

http://hg.mozilla.org/comm-central/index.cgi/rev/5a71d1e8b086
Attachment #330161 - Attachment description: (Ev1) </suite/common/bookmarks/*.xul> → (Ev1) </suite/common/bookmarks/*.xul> (Checked in)
Comment on attachment 330751 [details] [diff] [review]
(Cv1a) <urlbarBindings.xml>
[Checkin: Comment 16]

http://hg.mozilla.org/comm-central/index.cgi/rev/cb66b1639351
Attachment #330751 - Attachment description: (Cv1a) <urlbarBindings.xml> → (Cv1a) <urlbarBindings.xml> (Checked in)
Whiteboard: [c-n: Av1b, Bv1, Cv1a, Ev1 // Leave opened] → [Leave opened]
Attachment #330082 - Attachment description: (Av1b) </suite/common/permissions/*.xul> (Checked in) → (Av1b) </suite/common/permissions/*.xul> [Checkin: Comment 14]
Attachment #330161 - Attachment description: (Ev1) </suite/common/bookmarks/*.xul> (Checked in) → (Ev1) </suite/common/bookmarks/*.xul> [Checkin: Comment 15]
Attachment #330751 - Attachment description: (Cv1a) <urlbarBindings.xml> (Checked in) → (Cv1a) <urlbarBindings.xml> [Checkin: Comment 16]
Attachment #329942 - Attachment description: (Bv1) </suite/browser/pageinfo/*> (Checked in) → (Bv1) </suite/browser/pageinfo/*> [Checkin: Comment 13]
Blocks: 445374
No longer depends on: 445374
Whiteboard: [Leave opened]
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008072911 SeaMonkey/2.0a1pre] (home made) (W2Ksp4)

Fixes
{{
Error: missing ) after argument list
Source File: chrome://navigator/content/urlbarBindings.xml
Line: 392, Column: 68
Source Code:
                "searchFor", [kids[i].getAttribute("name"), val], 2); 
}}
caused by Cv1a patch :-<
Keywords: checkin-needed
Whiteboard: [c-n: Fv1 // Leave opened]
Comment on attachment 331619 [details] [diff] [review]
(Fv1) <urlbarBindings.xml> missing ")"
[Checkin: Comment 18]

I landed this
Serge - is there anything left to do here or can this be closed as fixed?
Keywords: checkin-needed
Whiteboard: [c-n: Fv1 // Leave opened]
Attachment #331619 - Attachment description: (Fv1) <urlbarBindings.xml> missing ")" → (Fv1) <urlbarBindings.xml> missing ")" [Checkin: Comment 18]
(In reply to comment #19)

Waiting for Dv1 patch (review).
Attachment #330160 - Flags: superreview?(neil)
Attachment #330160 - Flags: superreview?(jag)
Attachment #330160 - Flags: review?(neil)
Attachment #330160 - Flags: review?(jag)
Attachment #330160 - Flags: superreview?(neil)
Attachment #330160 - Flags: superreview+
Attachment #330160 - Flags: review?(neil)
Attachment #330160 - Flags: review+
Flags: in-litmus- → in-testsuite-
Keywords: checkin-needed
Whiteboard: [c-n: Dv1]
Comment on attachment 330160 [details] [diff] [review]
(Dv1) </suite/browser/*.xul>
[Checkin: Comment 21]

http://hg.mozilla.org/index.cgi/comm-central/rev/8a3e54a9ac15
Attachment #330160 - Attachment description: (Dv1) </suite/browser/*.xul> → (Dv1) </suite/browser/*.xul> [Checkin: Comment 21]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: Dv1]
Depends on: 445831
You need to log in before you can comment on or make changes to this bug.