445387 - In </suite/*>, "use a xul <stringbundle/> instead of including the strres.js code"

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

"Found 15 matching lines in 12 files"

minus the 2 <pref-languages*.xul> ready for checkin in bug 56680.

***

<pageInfo.xul> should be (kept in) sync' with the one from (FF) bug 445374.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) </suite/common/permissions/*.xul>

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) </suite/browser/pageinfo/*> [Checkin: Comment 13]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Comment 3

[Daniel Brooks [:db48x]]

Comment on attachment 329942 [details] [diff] [review]
(Bv1) </suite/browser/pageinfo/*>
[Checkin: Comment 13]

looks good, r=db48x

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) <urlbarBindings.xml>

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

It used the <strres.js> from (shared) <utilityOverlay.xul>,
which I'll submit a later/separate patch for.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) </suite/common/permissions/*.xul>

Av1, using |getStringBundle()| from Toolkit <contentAreaUtils.js> ;-)

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) </suite/common/permissions/*.xul> [Checkin: Comment 14]

Av1a, with s/Toolkit//, as SeaMonkey uses its forked file :-|

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1) </suite/browser/*.xul> [Checkin: Comment 21]

2 useless includes, as all (function) callers have been fixed in other patches.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1) </suite/common/bookmarks/*.xul> [Checkin: Comment 15]

2 useless includes, as all (function) callers have been fixed in other patches.

Comment 9

[Daniel Brooks [:db48x]]

Comment on attachment 330161 [details] [diff] [review]
(Ev1) </suite/common/bookmarks/*.xul> 
[Checkin: Comment 15]

would have liked to see this all as one patch, but it's ok. r=db48x

Comment 10

[Daniel Brooks [:db48x]]

Comment on attachment 330022 [details] [diff] [review]
(Cv1) <urlbarBindings.xml>

the searchValue setter could be simplified to use fewer variables, but it's no matter. r=db48x

Comment 11

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1a) <urlbarBindings.xml> [Checkin: Comment 16]

Cv1, with comment 10 suggestion(s).

Comment 12

[Ian Neal]

Serge, you still need sr on Av1b, Bv1, Cv1a, Ev1

Comment 13

[Ian Neal]

Comment on attachment 329942 [details] [diff] [review]
(Bv1) </suite/browser/pageinfo/*>
[Checkin: Comment 13]

http://hg.mozilla.org/comm-central/index.cgi/rev/b247c1a31380

Comment 14

[Ian Neal]

Comment on attachment 330082 [details] [diff] [review]
(Av1b) </suite/common/permissions/*.xul> 
[Checkin: Comment 14]

http://hg.mozilla.org/comm-central/index.cgi/rev/dd2b64479966

Comment 15

[Ian Neal]

Comment on attachment 330161 [details] [diff] [review]
(Ev1) </suite/common/bookmarks/*.xul> 
[Checkin: Comment 15]

http://hg.mozilla.org/comm-central/index.cgi/rev/5a71d1e8b086

Comment 16

[Ian Neal]

Comment on attachment 330751 [details] [diff] [review]
(Cv1a) <urlbarBindings.xml>
[Checkin: Comment 16]

http://hg.mozilla.org/comm-central/index.cgi/rev/cb66b1639351

Comment 17

[Serge Gautherie (:sgautherie)]

Attachment: (Fv1) <urlbarBindings.xml> missing ")" [Checkin: Comment 18]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008072911 SeaMonkey/2.0a1pre] (home made) (W2Ksp4)

Fixes
{{
Error: missing ) after argument list
Source File: chrome://navigator/content/urlbarBindings.xml
Line: 392, Column: 68
Source Code:
                "searchFor", [kids[i].getAttribute("name"), val], 2); 
}}
caused by Cv1a patch :-<

Comment 18

[Stefan [:stefanh]]

Comment on attachment 331619 [details] [diff] [review]
(Fv1) <urlbarBindings.xml> missing ")"
[Checkin: Comment 18]

I landed this

Comment 19

[Stefan [:stefanh]]

Serge - is there anything left to do here or can this be closed as fixed?

Comment 20

[Serge Gautherie (:sgautherie)]

(In reply to comment #19)

Waiting for Dv1 patch (review).

Comment 21

[Serge Gautherie (:sgautherie)]

Comment on attachment 330160 [details] [diff] [review]
(Dv1) </suite/browser/*.xul>
[Checkin: Comment 21]

http://hg.mozilla.org/index.cgi/comm-central/rev/8a3e54a9ac15