445497 - Ctrl-Tab preview should allow tabs to be clicked on

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[nightstalkerz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008071603 Minefield/3.1a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008071603 Minefield/3.1a1pre

When using Ctrl-Tab previews, they should be clickable so that the user can go to the specific tab quicker.

Reproducible: Always

Steps to Reproduce:
1. Press Ctrl + Tab
2. Try to click on a tab preview
3.
Actual Results:  
Nothing happens.

Expected Results:  
The tab clicked on will be displayed.

Comment 1

[Dão Gottwald [:dao]]

Ctrl-Tab is keyboard-orientated by design. Would prefer to wontfix this in favor of bug 436304.

Comment 2

[nightstalkerz]

Most users won't know about it and will probably complain if they can't click on something which looks like its clickable.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, on OS X its a common functionality. Switching between application by using Cmd+Tab let you choose the application with the mouse. The desired application under the cursor gets a hover style. That's a wonderful enhancement which I really miss on Windows.

Comment 4

[nightstalkerz]

You can do the same thing on Vista as well. This should be put in for OS integration.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

trivial patch

I'm not going to request ui-review, since beltzner is swamped and this is an unobtrusive feature that won't bother anyone who doesn't want to use it. Anything that goes beyond this (e.g. hover styling) can be handled in new bugs.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch v2

do stopScroll() before accessing this.selected. This is the correct behavior when Tab is released while scrolling.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/cbc68938b7cb

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, using the mouse to click on a preview doesn't work neither on Windows nor OS X with the latest nightly build.

If you want to get it to work on Windows XP you have to hold down the left mouse button while releasing the ctrl key. Now the crtl-tab panel is still visible and you can click a preview. Using OS X it doesn't work at all. Releasing the ctrl key closes the ctrl-tab panel.

With the tryserver build for all tabs preview it works fine as long as you don't have pressed the ctrl key. So I think we shouldn't catch the mouse click event because ctrl is clicked.

I think we should reopen the bug because the feature doesn't really work yet.

Comment 9

[nightstalkerz]

Ctrl + Tab works for me. Hold down Ctrl, then press tab. Release tab and you shpuld be able to click on the previews.

Works on Vista and XP.

Comment 10

[Dão Gottwald [:dao]]

WFM too.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #9)
> Ctrl + Tab works for me. Hold down Ctrl, then press tab. Release tab and you
> shpuld be able to click on the previews.
> 
> Works on Vista and XP.

I'm not the only one who is affected by this. Marcia has the same problems in getting it to work on Windows and OS X. Probably she will comment soon. Until then could you try to re-run the test with a fresh profile? Does it still work for you? No idea if this is VmWare related why it doesn't work for us. But at least on OS X there is no other software which can interferes us here.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, I got it to work on Windows XP running inside VmWare. The problem here is that you shouldn't have to be active OS X mouse actions. This option can be turned of in the VmWare preferences.

But on OS X it's a bit different. Here the combination ctrl + left click is used to open the context menu. Because we don't have such a menu we can't see anything. Dao, shall we also enable the control modifier here? 

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #12)
> But on OS X it's a bit different. Here the combination ctrl + left click is
> used to open the context menu. Because we don't have such a menu we can't see
> anything. Dao, shall we also enable the control modifier here? 

Filed that as bug 451604.

Meanwhile I can verify this enhancement with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080821034539 Minefield/3.1a2pre ID:20080821034539

We should add it to Litmus after the new testsuite has been created.

Comment 14

[Marcia Knous [:marcia]]

Henrik: Thanks for debugging the issue on Windows. I was running Vista in a VM, and now I understand why it was not working.

Comment 15

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7038 added to Litmus

Comment 16

[Al Billings [:abillings - ex-MoCo]]

We seem to have hidden this behind a pref (?) now and it is off by default. The testcase doesn't take this into account.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #16)
> We seem to have hidden this behind a pref (?) now and it is off by default. The
> testcase doesn't take this into account.

This testcase is disabled currently on Litmus.

Comment 18

[Al Billings [:abillings - ex-MoCo]]

Only if you just disabled it. It was in the Firefox 3.6 FFT run with all the other tab cases.

Comment 19

[Al Billings [:abillings - ex-MoCo]]

The case in question is https://litmus.mozilla.org/show_test.cgi?id=9057.