Closed Bug 445498 Opened 16 years ago Closed 8 years ago

Make background of Ctrl-Tab panel transparent on Linux

Categories

(Firefox :: Tabbed Browser, enhancement)

Product:
Firefox
Component:
Tabbed Browser
Platform:
x86
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: hidenosuke, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Screen shot for tab preview
90.09 KB, image/png
Details
ctrltab-panel.diff
1.98 KB, patch
mikedeboer
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Bug 395980 has been fixed.
But background of tab preview isn't transparent for Linux build.
Please see the screen shot.
It may be dup of bug 408284.
Blocks: 395980
Depends on: 408284
Severity: minor → enhancement
Summary: Background of tab preview isn't transparent → Make background of tab preview transparent on Linux
Alpha transparency on Linux requires advanced support from the videocard & driver.

Bug #408284 mentions using Compiz or falling back, but actually just Xcomposite support should be enough. However currently it's buggy or missing in most Xorg drivers - at least the opensource ones.

So... I think this should be postponed until it works more widely.
Blocks: ctrl-tab-panel
This is a direct copy of the Windows styling
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8776615 - Flags: review?(mdeboer)
Comment on attachment 8776615 [details] [diff] [review]
ctrltab-panel.diff

Review of attachment 8776615 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8776615 - Flags: review?(mdeboer) → review+
Summary: Make background of tab preview transparent on Linux → Make background of Ctrl-Tab panel transparent on Linux
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/8af80e4c3def
Make background of tab preview transparent on Linux. r=mdeboer
https://hg.mozilla.org/mozilla-central/rev/8af80e4c3def
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8776615 [details] [diff] [review]
ctrltab-panel.diff

Approval Request Comment
[Feature/regressing bug #]: bug 1116787
[User impact if declined]: bug 1116787 is in the release notes, so this feature will get more attention. would be nice to have it polished.
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: just copied the styling that we already used on Windows, low risk
[String/UUID change made/needed]: none
Attachment #8776615 - Flags: approval-mozilla-aurora?
Comment on attachment 8776615 [details] [diff] [review]
ctrltab-panel.diff

CSS only, low risk, Aurora50+
Attachment #8776615 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: