44552 - Finetune Intelligent Send

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Ben Bucksch (:BenB)]

We need to take care that we don't trigger the askSendFormat dialog too often.

2 cases are known:
1. We reply to a HTML msg containing a <div> or <span> that just includes
optional XML-like information using the |class| attribute.
2. We reply to a HTML msg that in turn replies to a plaintext msg and is sent by
a Mozilla, i.e. the quote part contains tags inserted by our recognizer. (The
"Send structs as styles" stuff is done after intelligent send, that's why you
need such complicated circumstances to see the problem.)

I consider the first one being quite severe, as it propably means that we cannot
send out <div>s as long as those Mozillas are in large use. But <div>s are cool.

Comment 1

[Ben Bucksch (:BenB)]

3. Reply to format=flowed (or any plaintext?) mails.

Comment 2

[Ben Bucksch (:BenB)]

Also, honor the pref for outputting structs.

Comment 3

[Ben Bucksch (:BenB)]

> 3. Reply to format=flowed (or any plaintext?) mails.

Has been resolved by another bug.

2. Isn't that bad anymore, because the "recognize structs during send" pref is
disabled by default and removed from the prefs UI.

1. remains. I'll propably just check for a style atribute, and if none exists,
ignore the span/div.

Comment 4

[Ben Bucksch (:BenB)]

> 2. Isn't that bad anymore, because the "recognize structs during send" pref is
> disabled by default and removed from the prefs UI.

That's why I decided not to check for these tags, for perf reasons. However, I
forgot the <a> stuff, which wasn't always recognized (e.g. email addresses). I
changed that.

Ignoring simple <div>s/<span>s and honoring the structs pref is also fixed.

Will attach patch. It will also contain a part of the fix for bug 52042.
ducarroz, please review.

Comment 5

[Ben Bucksch (:BenB)]

Attachment: Fix, Version 1

Comment 6

[Jean-Francois Ducarroz]

looks good. R=ducarroz

Comment 7

[Ben Bucksch (:BenB)]

Patch checked in. Mamrking FIXED. Please file new bugs, if you have other
suggestions for tuning.

Comment 8

[fenella]

Ben, can you give me some hint how to verify this bug?

Comment 9

[Ben Bucksch (:BenB)]

fenella,
2. and 3. above are propably not very important in practice, at least not yet.

You can verify 1. by manually creating an HTML msg containing a "<div
class=hello>This is a div with an arbitary class</div>" in the source.

As for the structs pref, en/disable pref "converter.html2txt.structs", make sure
you have the format pref to "ask" and send yourself a msg with (only) bold text.
Pref enabled: The askSendFormat comes up, telling you that it can convert the
msg to plaintext without losing info. Pref disabled: The dialog tells you that
it will not convert the formatting.

Comment 10

[Ben Bucksch (:BenB)]

> You can verify 1. by manually creating an HTML msg containing a "<div
> class=hello>This is a div with an arbitary class</div>" in the source.

..adn then reply to it. If there only that <div> as non-trivial formatting, the
askSendFormat dialog shouldn't come up.

Comment 11

[fenella]

Mac (2000-09-26-04 M18)
Linux (2000-09-26-06 M18)
Mac (2000-09-26-04 M18)
Verifying 1 works on on all platforms.