445768 - CTRL+Tab moves to location bar if only 1 tab is open.

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Marco Zehe (:MarcoZ)]

STR:
1. Open Firefox 3.1a1pre.
2. Open a single page, make sure no other tabs are open.
3. Press Ctrl+Tab.

Expected: Nothing happens.
Actual: Focus is moved to the Location bar.

Comment 1

[Shawn Wilsher :sdwilsh]

Should be easy to make a browser test for this.

Comment 2

[TheTallOne]

Pressing Ctrl+Tab then disables the F6 cycling, as seen in this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=426850

1. Press Ctrl+Tab with 1 window open.

It seems Ctrl+Tab acts the same as F6 and thus gets stuck after moving from frame 1 to frame 2. Possibly related?

Comment 3

[Hasham]

Confirmed on Windows.

Regression range is between:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008071504 Minefield/3.1a1pre

and 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008071603 Minefield/3.1a1pre

Comment 4

[u88484]

Hasham, can you find the regression between hourly builds between those nightly builds?  Just to narrow it down, also if you could post the link with the checkins between then, that would be great.

Comment 5

[Hasham]

Kurt, I couldn't access hourly builds on 7/15 because ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/ only gives builds from the past two days. I'm not aware of any hourly build archives so I couldn't really tell you a more specific time frame than that. Sorry :(

Comment 6

[Dão Gottwald [:dao]]

Bug 395980 caused this.

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

trivial fix

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 333295 [details] [diff] [review]
patch

>diff --git a/browser/base/content/test/browser_ctrlTab.js b/browser/base/content/test/browser_ctrlTab.js

>+  var eventConsumed = true;
>+  document.addEventListener("keypress", function (event) {
>+    eventConsumed = event.getPreventDefault();
>+  }, false);
>+  EventUtils.synthesizeKey("VK_TAB", { ctrlKey: true });
>+  ok(eventConsumed, "Ctrl+Tab consumed by the tabbed browser if one tab is open");

It would be good to also check that focus is correct (i.e. test for the symptom, not only the fix).

Comment 9

[Dão Gottwald [:dao]]

I wasn't able to get synthesizeKey("VK_TAB", { ctrlKey: true });
 change the focus even without this patch applied.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

I suppose the focus event is dispatched asynchronously.

Comment 11

[Dão Gottwald [:dao]]

checking focusedWindow did the trick...

http://hg.mozilla.org/mozilla-central/index.cgi/rev/315d6564407b

Comment 12

[Marco Zehe (:MarcoZ)]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080812045727 Minefield/3.1a2pre