Closed Bug 426850 Opened 16 years ago Closed 15 years ago

F6 no longer cycles to and from location bar

Categories

(Firefox :: Keyboard Navigation, defect)

Product:
Firefox
Component:
Keyboard Navigation
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: stephenloke, Unassigned)

References

Details

(Keywords: polish, regression) 

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5

I think this has been caused by Bug 413844.

In Firefox 3 Beta 2, pressing F6 moves the focus onto the location bar, and pressing again moves the focus back onto the main frame/window. However now, pressing F6 repeatedly has no effect, as shown in the following diagram:
Main window >>> Location Bar >>> Nothing

Yes, you can use Alt+D and Ctrl+L to select the location bar, however many users do use F6 to do so - it is simpler.

Basically, I think a change (fix for 413844??) caused this to happen. It was working in Fx3B2

Reproducible: Always

Steps to Reproduce:
1.Press F6 - Location Bar selected
2.Press F6 again - Nothing focused on
Actual Results:  
Nothing is focused on.

Expected Results:  
Focus switches back to window and pressing F6 again goes back to the location bar.
Done some searching, and have found that the failure occurs from the following nightly builds:
2008-03-20 - Pass
2008-03-21 - Fail
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Version: unspecified → Trunk
Not strictly Vista.

Also on windows server 2003

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008040303 Minefield/3.0pre
Confirming this on Linux as well.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008040304 Minefield/3.0pre ID:2008040304

This is probably for all builds.
OS: Windows Vista → All
Definitely see it on XP.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032714 Minefield/3.0pre
Also in XP
Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Confirmed in Linux (Ubuntu 8.04) with included package (Fx3b5) and latest nightly trunk.

Mozilla/5.0 (X11; U; Linux i686; es-AR; rv:1.9b5) Gecko/2008041514 Firefox/3.0b5

Also, if you do these cycle:

1.- Press F6 (location bar selected).
2.- Press F6 (nothing selected, even if you press F6 many times).
3.- Press Shift+F6 (main content selected, even if you press Shift+F6 many times)
4.- Press F6 (location bar selected again).

Weird...
Flags: blocking-firefox3?
(In reply to comment #1)
> Done some searching, and have found that the failure occurs from the following
> nightly builds:
> 2008-03-20 - Pass
> 2008-03-21 - Fail

This Bonsai query shows what changed between those two builds:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-20&maxdate=2008-03-21+05%3A00&cvsroot=%2Fcvsroot
This is unfortunate but given:

a) You can focus location bar it is focusing out that is broken
b) It shipped in Beta5 with this without any dups here

I think we can't hold FF3 for this.  If we get a patch we can take it in 3.0.1 or RC2 (if there is one).
Flags: blocking-firefox3? → blocking-firefox3-
I can confirm the bug too. I'm on FF 3.0B5 (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5)

It is possible to use the Keyconfig add-on though to work around this bug. That I have also described here: http://forums.mozillazine.org/viewtopic.php?p=3393753#3393753
Just confirming that this bug "shipped" on Firefox 3.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0 ID:2008052906
Flags: blocking-firefox3.1?
Maybe this is not a bug after all, as per the documentation http://support.mozilla.com/en-US/kb/Keyboard+shortcuts to "Select Location Bar" the shortcuts are:
Windows: "Alt+D" and "Ctrl+L"
Linux: "Alt+D" and "Ctrl+L"
Mac OS: "F6" and "Cmd+L"

So anyone can confirm on Mac OS? But even on Windows and Linux "F6" half works as per the original description of the bug.

My 2¢
Alex: Also in the documentation you gave above, it says that F6 now 'Moves to Next Frame' and Shift+F6 'Moves to Previous Frame'. Essentially we still should be able to cycle through all the frames in a circle: Frame 1>Frame2>Frame3>Frame1 and not get stuck at frame 2.
Confirmed for me on Windows XP SP3, FF v3.0.1 on 7/16/08
Somebody for the love of god FIX THIS ><
Is that really the right regression range - how strange.
(In reply to comment #17)
> Is that really the right regression range - how strange.
> 
If I can rely on the correctness of the ID's of builds, yes.
ID 2008032103 WFM; ID 2008032107 fails. 


I've double(In reply to comment #18)
> (In reply to comment #17)
> > Is that really the right regression range - how strange.
> > 
> If I can rely on the correctness of the ID's of builds, yes.
> ID 2008032103 WFM; ID 2008032107 fails. 
> 
I've just double checked - the above ranges are correct.

Just to report that this still broken on:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a1) Gecko/2008072310 Shiretoko/3.1a1 ID:2008072310
Reconfirmed in 3.0.3

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3

Running XP Pro/Corp SP3.
We don't need additional reconfirmations for every version that comes out. This is a confirmed bug in the Firefox 3.x codebase, and there's been no fix coming, nor does it look like Smaug understands what in his patch could have caused it.

Aaron/Marco: have any other problems with frame navigation come up?
Flags: blocking-firefox3.1? → blocking-firefox3.1-
Keywords: polish
Worksforme in 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081109 Minefield/3.1b2pre

Very strange.
Worksforme too, Linux/trunk.
->WFM

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081110 Minefield/3.1b2pre
+ previous comments
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
Would be great if someone has time to write a mochitest (or perhaps browser-chrome test) for this.
Flags: in-testsuite?
Resolution: WORKSFORME → FIXED
rv:1.9.1b2pre is a beta release isn't it?
Most up-to-date stock listing is rv:1.9.0.3
Technically not resolved until patched to mainstream releases.
Bugs in bugzilla are resolved when they're fixed on the development trunk. Flags indicate whether or not the fix is backported to one of the stable branch. Since it's not clear what fixed this, it's unlikely to be fixed on the 3.0 branch.
Resolution: FIXED → WORKSFORME
Re-opening as bug 484642 indicates that this is happening on trunk and branch.
Status: RESOLVED → REOPENED
Flags: blocking-firefox3.5- → blocking-firefox3.5?
Resolution: WORKSFORME → ---
For my case in bug 484642 Firebug gets focus instead of the page on the third press of F6.
Firebug issue on this http://code.google.com/p/fbug/issues/detail?id=523 John Barton marked the Firebug issue invalid.
Marcel: do you have Firebug installed? Looks like this is a known problem with older versions of that add-on, though fixed in the latest version.
Flags: blocking-firefox3.5? → blocking-firefox3.5-
I have this problem with firebug 1.4.0a13 which is the latest version.
Still Confirmed Broken
If I hit F6 twice I just hit tab now and it cycles back -shrug-

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7
Flags: blocking-firefox3.6?
oh, I'm sorry, should tested it with a new profile before filing a bug ;/

(In reply to comment #35)
> Marcel: do you have Firebug installed? Looks like this is a known problem with
> older versions of that add-on, though fixed in the latest version.
So is anyone seeing this bug without Firebug installed?
Confirmed in 3.0.10 without Firebug.
I see this bug with a new profile with no extensions in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.12pre) Gecko/2009052004 GranParadiso/3.0.12pre,

but not in:
Mozilla/5.0 (X11; U; Linux i686; eo; rv:1.9.1b5pre) Gecko/20090520 Shiretoko/3.5b5pre
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090520 Minefield/3.6a1pre
Appears fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
Works ok for me in Firefox/3.5.2 on Win7
--> WFM based on comment 41, comment 42 and comment 43 as well as my own testing.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 15 years ago
Flags: blocking-firefox3.6? → blocking-firefox3.6-
Resolution: --- → WORKSFORME
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.