Closed Bug 445790 Opened 12 years ago Closed 12 years ago

Use |gUtilityBundle| everywhere in <utilityOverlay.js>

Categories

(SeaMonkey :: General, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.0a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 408190 added |<stringbundle id="bundle_utilityOverlay"| for its own use.

Yet, the rest of the file should be converted to use it too ;-)
Attached patch (Av1) <utilityOverlay.*> (obsolete) — Splinter Review
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Other |srGetStrBundle()| callers which do/may depend on this <strres.js> are/will fixed in separate patch(es),
as in bug 445387 patch C.
Assignee: general → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #330055 - Flags: superreview?(neil)
Attachment #330055 - Flags: review?(neil)
Comment on attachment 330055 [details] [diff] [review]
(Av1) <utilityOverlay.*>

>-    var allowString = bundle.formatStringFromName("popupAllow", [uri.host], 1);
>+    const allowString = gUtilityBundle.getFormattedString("popupAllow", [uri.host]);

>-    var str = bundle.formatStringFromName('popupMenuShow',
>-                                          [popup.popupWindowURI.spec], 1);
>+    const str = gUtilityBundle.getFormattedString("popupMenuShow",
>+                                                  [popup.popupWindowURI.spec]);
These can stay as var, please.
Attachment #330055 - Flags: superreview?(neil)
Attachment #330055 - Flags: superreview+
Attachment #330055 - Flags: review?(neil)
Attachment #330055 - Flags: review+
Av1, with comment 2 suggestion(s).

(In reply to comment #2)
> These can stay as var, please.

Sure, even if I don't see why this is better...
Attachment #330055 - Attachment is obsolete: true
Flags: in-litmus-
Keywords: checkin-needed
Blocks: 448137
Landed attachment #330225 [details] [diff] [review]:

http://hg.mozilla.org/index.cgi/comm-central/rev/2ef7740a6f7c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008072716 SeaMonkey/2.0a1pre] (home made) (W2Ksp4)

V.Fixed
Status: RESOLVED → VERIFIED
No longer blocks: 448137
Attachment #330225 - Attachment description: (Av1a) <utilityOverlay.*> → (Av1a) <utilityOverlay.*> [Checkin: Comment 4]
Flags: in-litmus- → in-testsuite-
You need to log in before you can comment on or make changes to this bug.