Closed Bug 445890 Opened 13 years ago Closed 13 years ago
Request .response Xml not accessible from signed remote XUL code
To be complete, the unsigned version of the script is directly accessible here: http://www.lowcoders.fr/xul/index.xul
Component: General → DOM
Product: Firefox → Core
QA Contact: general → general
Version: 2.0 Branch → unspecified
Yeah. The problem is that the signed script and the data gotten via XMLHttpRequest are different origins, since said data doesn't come from inside the signed jar. On trunk, we set the calling document principal on the XMLHttpRequest response (see bug 326337), but that change never landed on branch, so we get this bug.
So this would be fixed by a branch version of the patch in bug 326337?
Assignee: nobody → peterv
Depends on: 326337
I would think so, yes.
If you want this fixed in the next three weeks you'll need to find a better owner.
Johnny or Boris, can you take this on?
Moving out to 18.104.22.168 since peterv is out of town.
Flags: blocking22.214.171.124+ → blocking126.96.36.199+
Attachment #335415 - Flags: review? → review?(Olli.Pettay)
Comment on attachment 335415 [details] [diff] [review] This should do the trick It is different question if we need Bug 421228 on 1.8.
Attachment #335415 - Flags: review?(Olli.Pettay) → review+
Gah. Yes, we'd need that; good catch. But there is no nullprincipal on 1.8... I guess we could make it use about:blank?
Actually, I don't think we need it. The data document content policy won't get bypassed on branch, and that's all that really matters here, I think.
Attachment #335415 - Flags: superreview?(jst) → superreview+
Attachment #335415 - Flags: approval188.8.131.52?
Comment on attachment 335415 [details] [diff] [review] This should do the trick Is it going to matter that in a redirect case the principal doesn't get updated? On branch they're guaranteed same-origin so they would at least be equivalent principals, but is this case handled OK for XS-XHR on trunk? regardless, for 1.8 branch approved for 184.108.40.206, a=dveditz for release-drivers
Attachment #335415 - Flags: approval220.127.116.11? → approval18.104.22.168+
Fix checked into 1.8 branch.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
We don't have XS-XHR on trunk yet, and when we do we'll likely still stamp the document with the loader principal so that the loader can actually get that data. Thanks for checking this in!
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:22.214.171.124) Gecko/2008082909 Firefox/126.96.36.199.
Removing the blocker flag for a release _after_ the one this was fixed in, since it's not really relevant anymore.
You need to log in before you can comment on or make changes to this bug.