445892 - Unregress, then fix, |gCollect*| processing

Status: RESOLVED INVALID

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Bug 308988 comment 30 checkin missed a |!|;
in fact, there was no reason to change the way the conditions were written.

Furthermore, I don't know/test if it's a regression or not,
but the current behavior is wrong, as |gCollectIncoming| and |gCollectNewsgroup| are "merged" into |createCard|,
so setting any of them as |true| will override the other one :-(

NB: TB doesn't have (any of) this code anymore (after bug 331924).

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Obvious unregression only

Actually,
r1.147 only "restored" these conditions as they were before bug 308988;
yet, r1.146 was correct/better on this part.

This is only a small/trivial step/fix in the right direction:
the code and comment of this block needs to be reanalyzed and fixed,
to handle correctly/"separately" the 3 preferences.

Comment 2

[Serge Gautherie (:sgautherie)]

Another (future) point, from bug 65613 comment 8:
{{
Karsten Düsterloh   2008-07-18 01:07:06 PDT

probably not auto-grabbing addresses filtered away by the junk filter (or some such in this direction)
}}

Comment 3

[Ian Neal]

The logic is correct as mentioned in bug 308988, dontCollectAddress is a misnamed variable, it would probably be better named "fromNewsgroup"

So the logic is:
create a card if (pref for incoming and not from a newsgroup) or (pref for newsgroups and from a newsgroup).

-> INVALID

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> The logic is correct as mentioned in bug 308988, dontCollectAddress is a
> misnamed variable, it would probably be better named "fromNewsgroup"

I filed bug 498215.