331924 - message header view cleanup

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

Before I get cracking on custom headers for the message pane instead of view all headers, there's some code cleanup I want to do.

Comment 1

[Scott MacGregor]

Attachment: use a deck to toggle between the collapsed and expanded view

Comment 2

[Scott MacGregor]

Comment on attachment 216481 [details] [diff] [review]
use a deck to toggle between the collapsed and expanded view

use a deck to control the collapsed and expanded header view. The deck does most of the work for us that we were doing in JS.

Comment 3

[Scott MacGregor]

Attachment: start removing obsolete "keyword" stuff

this starts to rip out the keyword stuff which was added for Netscape back in 2002 so they could add extra UI stuff.

Comment 4

[Scott MacGregor]

Attachment: remove netscape instant messenger buddy icon code

I'm not adverse to support images in the message header pane (x-face, etc.), but we won't do it by looking for netscape instant messaging file screen name paths in your profile since we don't use netscape instant messenger anymore.

Comment 5

[Scott MacGregor]

Attachment: remove functionality for collecting e-mail addresses when you read the message

we turned this functionality off a long time ago, it made it too easy to get spam addresses into your address book. This just removes the code that looks at the pref all together.

Comment 6

[Scott MacGregor]

the keyword patch broke message header display on the 2.0 branch due to a bad merge. I just fixed that so tomorrow's builds should be all better.

Comment 7

[Worcester12345]

Did this cause Bugzilla Bug 332267 header + not working?

So far, it seems better with version 2 alpha 1 (20060331)

Comment 8

[Scott MacGregor]

I didn't have any more open items for this.

Comment 9

[Worcester12345]

Can we get this bug fixed on branch also? I did a bug for branch, but it was duped to this one. Thanks.