44613 - pr_Mac_LoadIndexedFragment leaks PRLibrary on failure

Status: VERIFIED DUPLICATE of bug 45432

(NSPR :: NSPR, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When pr_Mac_LoadIndexedFragment fails to load a library (there was an error 
message about failing to load the PSMGlue library when I started up), a PRLibrary 
object (20 bytes) is leaked.  I think the last "goto unlock" in the function 
should have a "delete newLib" right before it (within the "if (err != noErr)").

From leaksoup:
0x0A2E5AD0 [0] <void*> (20){20}
        0x00000000
        0x00000000
        0x00000000
        0x00000000
        0x00000000
calloc
PR_Calloc
pr_Mac_LoadIndexedFragment
PR_LoadLibraryWithFlags
nsLocalFile::Load(PRLibrary**)
nsDll::Load()
nsNativeComponentLoader::SelfRegisterDll(nsDll*, const char*, int)
nsNativeComponentLoader::AutoRegisterComponent(int, nsIFile*, int*)
nsNativeComponentLoader::RegisterComponentsInDir(int, nsIFile*)
nsNativeComponentLoader::AutoRegisterComponents(int, nsIFile*)
nsComponentManagerImpl::AutoRegister(int, nsIFile*)
nsComponentManager::AutoRegister(int, nsIFile*)
nsViewerApp::AutoregisterComponents()
nsViewerApp::SetupRegistry()
nsViewerApp::Initialize(int, char**)
main
__NSInitialize(1BAC61C4)

Comment 1

[Steve Dagley]

Thanks David, I'll take a look at it.

Comment 2

[Wan-Teh Chang]

Patrick Beard filed a bug report on the same bug,
so I'm going to mark this one as a duplicate.

*** This bug has been marked as a duplicate of 45432 ***

Comment 3

[Scott Brodmerkle]

Verified dupe.