44620 - emailregexp: editusers.cgi should use emailregexp

Status: VERIFIED DUPLICATE of bug 32971

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Tak]

In the admin section you can specify a regular expression Param() that defines 
valid email addresses.  In various places this regex is used to enforce your 
choice of userids  (with or without @domain.com being the primary use).

Works great.

However, EditUsers.cgi is one program that missed that parameterization 
and has a hard-coded regular expression. 

Patch follows:

Comment 1

[Tak]

Index: editusers.cgi
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v
retrieving revision 1.9
diff -r1.9 editusers.cgi
378a379
>     my $emailregexp = Param("emailregexp");
386c387
<     unless ($user =~ /^[^\@]+\@[^\@]+$/) {
---
>     unless ($user =~ m/$emailregexp/ ) {

Comment 2

[Jon Robertson]

This bug is a duplicate of bug 32971 and a duplicate of bug 34017.

These entries are really easy to find.  If you query for emailregexp in the 
description all three entries are returned in the buglist.

Comment 3

[andy]

This is a more complete patch that corrects the error message returned:

--- editusers.cgi-orig  Tue Jul 11 16:50:11
2000                                                      
+++ editusers.cgi       Tue Jul 11 16:57:02
2000                                                      
@@ -368,6 +368,7
@@                                                                                   
     my $realname = trim($::FORM{realname} ||
'');                                                    
     my $password = trim($::FORM{password} ||
'');                                                    
     my $disabledtext = trim($::FORM{disabledtext} ||
'');                                            
+    my $emailregexp =
Param('emailregexp');                                                          
                                                                                                      
     unless ($user)
{                                                                                 
         print "You must enter a name for the new user. Please
press\n";                              
@@ -375,9 +376,9
@@                                                                                   
        
PutTrailer($localtrailer);                                                                   
        
exit;                                                                                        
    
}                                                                                                
-    unless ($user =~ /^[^\@]+\@[^\@]+$/)
{                                                           
-        print "The user name entered must be a valid e-mail address. Please
press\n";                
-        print "<b>Back</b> and try
again.\n";                                                        
+    unless ($user =~ /$emailregexp/)
{                                                               
+        print
Param('emailregexpdesc');                                                              
+        print " Please press <b>Back</b> and try
again.\n";                                          
        
PutTrailer($localtrailer);                                                                   
        
exit;                                                                                        
    
}                                                                                                

Comment 4

[Dave Miller [:justdave]]

For anyone following this, the patch on this bug will get checked in as the 
resolution to bug 32971.


*** This bug has been marked as a duplicate of 32971 ***

Comment 5

[Scott Brodmerkle]

Verified dupe.

Comment 6

[Dave Miller [:justdave]]

moving to Bugzilla product
reassign to default owner/qa for INVALID/WONTFIX/WORKSFORME/DUPLICATE