32971 - edituser.cgi "new" checks user against bultin regular expression

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Robert Minsk]

edituser.cgi
    unless ($user =~ /^[^\@]+\@[^\@]+$/) {
        print "The user name entered must be a valid e-mail address. Please
press\n";
        print "<b>Back</b> and try again.\n";
        PutTrailer($localtrailer);
        exit;
    }

Notice how the $user is checked against /^[^\@]+\@[^\@]+$/.  It should be
checked against Param("emailregexp");

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Jon Robertson]

This bug still exists in 2.10 and is duplicated by bug #34017

Comment 3

[Jon Robertson]

For those following this bug, it has been duplicated again by bug 44620.  
However, bug 44620 does contain a patch!  :)

Comment 4

[Dave Miller [:justdave]]

another patch here waiting...  (maybe you can follow and appropriately mark the 
duplicates while you're at it)

Comment 5

[Dave Miller [:justdave]]

*** Bug 44620 has been marked as a duplicate of this bug. ***

Comment 6

[Dave Miller [:justdave]]

The following patch was posted to bug 44620 by [e-mail], which ended 
up being a duplicate of this bug.

Comment 7

[Dave Miller [:justdave]]

Attachment: Patch submitted by [e-mail] to fix this bug

Comment 8

[Dave Miller [:justdave]]

Patch has been checked in.

Comment 9

[Scott Brodmerkle]

*** Bug 34017 has been marked as a duplicate of this bug. ***

Comment 10

[Dave Miller [:justdave]]

*** Bug 58464 has been marked as a duplicate of this bug. ***

Comment 11

[Dave Miller [:justdave]]

In search of accurate queries....  (sorry for the spam)

Comment 12

[Gervase Markham [:gerv]]

This is a trivial fix which is a pain to verify. So VERIFYING based on 
inspection ;-)

Gerv

Comment 13

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product