Closed Bug 446612 Opened 12 years ago Closed 12 years ago

[mr] Search engine setup for Firefox 3 for Marathi.

Categories

(Mozilla Localizations :: mr / Marathi, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

Details

Attachments

(1 file)

Moving some existing work to more granular bugs.

We want to ship Firefox 3 a good list of search engines for Marathi.

We've come up with a good set in our work towards fx2 in bug 410783 comment 19. That should already be implemented, leaving this open for source verification.

Sandeep, please don't commit any modifications in l10n/mr/browser/searchplugins to the cvs repository without a patch reviewed by Axel or someone else appointed by Mic. The data here is sensitive to users and our search partners, thus the extra care here.
from previous bug
Google (geotargetted redirects on their side)
Yahoo (from India)
Amazon.com
creative commons
eBay (from India)
rediff (from India)
wikipedia (marathi)
TODO: remove answers from the list.
From comment #2

------------first part starts---------------------

[sshedmak@sshedmak searchplugins]$ pwd
/home/sshedmak/cvs/Jul08_MOZ/l10n/mr/browser/searchplugins

[sshedmak@sshedmak searchplugins]$ ls
CVS  eBay-in.xml  list.txt  rediff.xml  wikipedia-mr.xml  yahoo-in.xml

[sshedmak@sshedmak searchplugins]$ cat list.txt 
google
amazondotcom
eBay-in
yahoo-in
creativecommons
answers
wikipedia-mr
rediff
--------------first part ends----------------------------------


Wrt first part above: 
Pike, If time is pressing can i remove 'answers' entry from the list.txt ?



--------------second part starts--------------------------------

[sshedmak@sshedmak searchplugins]$ pwd
/home/sshedmak/cvs/Jul08_MOZ/mozilla/browser/locales/en-US/searchplugins

[sshedmak@sshedmak searchplugins]$ ls
amazondotcom.xml  answers.xml  creativecommons.xml  CVS  eBay.xml  google.xml  list.txt  wikipedia.xml  yahoo.xml

--------------second part ends ------------------------------------

Wrt second part:

Pike, If 'answers' is removed from the list.txt (from 'mr' locale) then should answers.xml be retained or removed in 'en-US' locale?
Re #1, yes, a patch doing that in this bug would help greatly.

Re #2, we're still shipping en-US with answers (and other locales), so there's nothing do for you there. Not that you could, you don't have write access to en-US ;-)
Comment on attachment 332558 [details] [diff] [review]
bug446612-removed 'answers' from l10n/mr/browser/searchplugins/list.txt

r=me, please land this with a check-in comment referencing this bug and my review, something like "bug 446612, remove answers from Marathi build, r=l10n@mozilla.com" would do.

For future review requests, it's a good idea to actually enter a requestee for the review, otherwise they tend to fall through the cracks. Bugzilla doesn't always autocomplete right, so enter the full bugmail address if you're in doubt.
Attachment #332558 - Flags: review? → review+
from comment #6

landing done.
Has this bug reached Status: RESOLVED FIXED   or   any input is still required from my side?


Thanks.
Yep, this is FIXED, thanks.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.