446612 - [mr] Search engine setup for Firefox 3 for Marathi.

Status: RESOLVED FIXED

(Mozilla Localizations :: mr / Marathi, defect)

Description

[Axel Hecht [:Pike]]

Moving some existing work to more granular bugs.

We want to ship Firefox 3 a good list of search engines for Marathi.

We've come up with a good set in our work towards fx2 in bug 410783 comment 19. That should already be implemented, leaving this open for source verification.

Sandeep, please don't commit any modifications in l10n/mr/browser/searchplugins to the cvs repository without a patch reviewed by Axel or someone else appointed by Mic. The data here is sensitive to users and our search partners, thus the extra care here.

Comment 1

[Mic Berman]

from previous bug
Google (geotargetted redirects on their side)
Yahoo (from India)
Amazon.com
creative commons
eBay (from India)
rediff (from India)
wikipedia (marathi)

Comment 2

[Axel Hecht [:Pike]]

TODO: remove answers from the list.

Comment 3

[sandeep shedmake]

From comment #2

------------first part starts---------------------

[sshedmak@sshedmak searchplugins]$ pwd
/home/sshedmak/cvs/Jul08_MOZ/l10n/mr/browser/searchplugins

[sshedmak@sshedmak searchplugins]$ ls
CVS  eBay-in.xml  list.txt  rediff.xml  wikipedia-mr.xml  yahoo-in.xml

[sshedmak@sshedmak searchplugins]$ cat list.txt 
google
amazondotcom
eBay-in
yahoo-in
creativecommons
answers
wikipedia-mr
rediff
--------------first part ends----------------------------------


Wrt first part above: 
Pike, If time is pressing can i remove 'answers' entry from the list.txt ?



--------------second part starts--------------------------------

[sshedmak@sshedmak searchplugins]$ pwd
/home/sshedmak/cvs/Jul08_MOZ/mozilla/browser/locales/en-US/searchplugins

[sshedmak@sshedmak searchplugins]$ ls
amazondotcom.xml  answers.xml  creativecommons.xml  CVS  eBay.xml  google.xml  list.txt  wikipedia.xml  yahoo.xml

--------------second part ends ------------------------------------

Wrt second part:

Pike, If 'answers' is removed from the list.txt (from 'mr' locale) then should answers.xml be retained or removed in 'en-US' locale?

Comment 4

[Axel Hecht [:Pike]]

Re #1, yes, a patch doing that in this bug would help greatly.

Re #2, we're still shipping en-US with answers (and other locales), so there's nothing do for you there. Not that you could, you don't have write access to en-US ;-)

Comment 5

[sandeep shedmake]

Attachment: bug446612-removed 'answers' from l10n/mr/browser/searchplugins/list.txt

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 332558 [details] [diff] [review]
bug446612-removed 'answers' from l10n/mr/browser/searchplugins/list.txt

r=me, please land this with a check-in comment referencing this bug and my review, something like "bug 446612, remove answers from Marathi build, r=[e-mail]" would do.

For future review requests, it's a good idea to actually enter a requestee for the review, otherwise they tend to fall through the cracks. Bugzilla doesn't always autocomplete right, so enter the full bugmail address if you're in doubt.

Comment 7

[sandeep shedmake]

from comment #6

landing done.

Comment 8

[sandeep shedmake]

Has this bug reached Status: RESOLVED FIXED   or   any input is still required from my side?


Thanks.

Comment 9

[Axel Hecht [:Pike]]

Yep, this is FIXED, thanks.