447814 - Reloading remote calendars shows wrong progress in status bar

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17pre) Gecko/20080723 Calendar/0.9pre

Reloading remote calendars shows wrong progress in status bar, i.e. "Reloading calendar 174 of 24"

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

I talked to Daniel about this topic. He said that it looks like we are having several composite calendars. I still do not know the reason for this issue for sure, because I thought due to the implementation of the function "getCompositeCalendar()" I took adequately care that no other composite calendars are existing. Grepping over the project showed me that there is yet another composite calendar for the imip bar ("createItipCompositeCalendar()". However with this patch I made the code of the statusbar now more tolerant, so that it automatically takes care the progress for each calendar is displayed only once.

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 335700 [details] [diff] [review]
patch v. #1

>+                 if (this.mCalendars[aCalendar.id] == null) {
Please use !this.mCalendars[aCalendar.id] or this.mCalendars[aCalendar.id] === undefined.

>+                     this.mCalendars[aCalendar.id] = aCalendar.name;
use true here

r=dbo

Comment 3

[Berend Cornelius]

considered comment #2,
checked in patch on trunk and MOZILLA_1_8_BRANCH

-> fixed

Comment 4

[Andreas Treumann]

Checked in lightning 2008082818 and sunbird 20080828 -> VERIFIED.