Closed
Bug 448114
Opened 17 years ago
Closed 16 years ago
Notify about non-finalized statements in debug builds
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.95 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
We can iterate the non-finalized statements by using sqlite3_next_stmt, and display the sql string so consumers know exactly what statements have not been finalized.
|
Assignee | |
Comment 1•17 years ago
|
||
|
|
Assignee | |
Comment 2•17 years ago
|
||
That wasn't going to build on windows
Attachment #347405 -
Attachment is obsolete: true
Attachment #347411 -
Flags: review?(bugmail)
Attachment #347405 -
Flags: review?(bugmail)
|
||
Comment 3•17 years ago
|
||
tested working on Windows, nice work!
|
||
Updated•17 years ago
|
Attachment #347411 -
Flags: review?(bugmail) → review+
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 347411 [details] [diff] [review]
v1.1
Immediately useful off the bat! I thought it was gloda's fault that sqlite3 was having trouble shutting down, but it turns out they were moz_cookies statements!
|
|
Assignee | |
Comment 5•17 years ago
|
||
(In reply to comment #4)
> (From update of attachment 347411 [details] [diff] [review])
> Immediately useful off the bat! I thought it was gloda's fault that sqlite3
> was having trouble shutting down, but it turns out they were moz_cookies
> statements!
Yup. Now people can stop asking me about it, and start blaming cookies.
Whiteboard: [has patch][has review][can land]
|
|
Assignee | |
Comment 6•17 years ago
|
||
This will need approval to land. Can't request it yet...
Whiteboard: [has patch][has review][can land] → [has patch][has review]
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][has review] → [has patch][has review][can land]
|
|
Assignee | |
Comment 7•16 years ago
|
||
Not going to bother landing this on branch.
http://hg.mozilla.org/mozilla-central/rev/ef6466eb4ae6
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
Target Milestone: --- → mozilla1.9.2a1
|
||
Comment 8•16 years ago
|
||
Filed bug 468744 on the cookie issue.
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•