468744 - "WARNING: sqlite3_close failed" on shutdown due to cookies

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Jesse Ruderman]

Thanks to the fix for bug 448114, we now know that the "sqlite3_close failed" warning on shutdown is due to Cookies code forgetting to finalize its statements.  Also thanks to that fix, the bug now causes four lines of console noise instead of one ;)

WARNING: SQL statement 'UPDATE moz_cookies SET lastAccessed = ?1 WHERE id = ?2' was not finalized: file /Users/jruderman/central/storage/src/mozStorageConnection.cpp, line 249

WARNING: SQL statement 'DELETE FROM moz_cookies WHERE id = ?1' was not finalized: file /Users/jruderman/central/storage/src/mozStorageConnection.cpp, line 249

WARNING: SQL statement 'INSERT INTO moz_cookies (id, name, value, host, path, expiry, lastAccessed, isSecure, isHttpOnly) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9)' was not finalized: file /Users/jruderman/central/storage/src/mozStorageConnection.cpp, line 249

WARNING: sqlite3_close failed. There are probably outstanding statements that are listed above!: file /Users/jruderman/central/storage/src/mozStorageConnection.cpp, line 262

Comment 1

[[e-mail]]

Attachment: patch v1

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 352250 [details] [diff] [review]
patch v1

The same lines of code in three places?  This is screaming to be made into a private method.

Comment 3

[[e-mail]]

Attachment: v2

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 352255 [details] [diff] [review]
v2

oh hai

r=sdwilsh

Comment 5

[[e-mail]]

pushed as http://hg.mozilla.org/mozilla-central/rev/fd7c994ec1e9.

Comment 6

[Seth Spitzer]

from bug #481775, it looks like this issue will be fixed for 1.9.1 as well, right?

Comment 7

[[e-mail]]

This should be totally independent of bug 481775. Are you seeing these assertions on 1.9.1?

Comment 8

[Seth Spitzer]

Dan, was http://hg.mozilla.org/mozilla-central/rev/fd7c994ec1e9 pushed to 1.9.1, or just the trunk?

Comment 9

[[e-mail]]

Ah, yes, I missed your point. This was pushed as part of that bug for 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ff0bc8ee6e31

Comment 10

[Seth Spitzer]

thanks for clarifying dan.