448168 - Apply |s/entires/entries/g|

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

Comment 1

[Robert Sesek]

Attachment: Patch

This patch only touches comments, not any code.

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 355148 [details] [diff] [review]
Patch

This patch is missing
/security/nss/lib/ssl/ssl.h

You need to choose a reviewer:
either a "global" one, or it may be easier to separate the patch per code areas.

Comment 3

[Robert Sesek]

(In reply to comment #2)
> (From update of attachment 355148 [details] [diff] [review])
> This patch is missing
> /security/nss/lib/ssl/ssl.h
> 
> You need to choose a reviewer:
> either a "global" one, or it may be easier to separate the patch per code
> areas.

Thanks. I've fixed that one. Where can I find a global reviewer (don't see them listed in the owners list)? If I were to separate this out into the individual modules, that'd be 8 different patches, which seems a little excessive for such a simple change.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)

> Where can I find a global reviewer (don't see them listed in the owners list)?

Sure, the closest are super-reviewers...

> If I were to separate this out into the individual modules, that'd be 8
> different patches, which seems a little excessive for such a simple change.

No trivial answer: see what is easier to get review(s)...

Comment 5

[Robert Sesek]

Attachment: Patch v2

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 355314 [details] [diff] [review]
Patch v2

r/sr=dveditz for everything except the two security/nss files. You'll have to get the NSS team to review those.

Comment 7

[Serge Gautherie (:sgautherie)]

Robert, ping for progress status.

Comment 8

[Ed Morley [:emorley]]

Attachment: Patch v3

Updated patch on behalf of Robert, so we can get this into the tree. Some of the instances of "entires" no longer exist, but new ones have cropped up. Patch format corrected + author set to Robert.

Re-requesting review due to changes now being made to files not included in the Robert's previous patch.

Comment 9

[Ed Morley [:emorley]]

Meant to say that there is now only one instance of "entires" in NSS (http://mxr.mozilla.org/mozilla-central/source/security/nss/lib/ssl/ssl.h#386), so have just missed out NSS changes for now.

Comment 10

[Ed Morley [:emorley]]

Ping for review (comment only changes). Thanks :-)

Comment 11

[Ed Morley [:emorley]]

Comment on attachment 543664 [details] [diff] [review]
Patch v3

Adding alternative reviewer for this comment-only typo fix patch, so we can get a new contributor's first patch into the tree. Thanks :-)

Comment 12

[Ed Morley [:emorley]]

Attachment: Patch v3.1

Updated commit message for r=roc, no other changes; carrying forwards r+.

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #12)
> carrying forwards r+.

This isn't helpful, just adds confusion. You didn't review the patch, dveditz did -- and the patch incorrectly says roc.

Comment 14

[Ed Morley [:emorley]]

Roc reviewed the newer version, see comment 11.
Point taken about clarity, the feedback is appreciated :-)

Comment 15

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/49f8fb1d048f