448339 - Thunderbird 3 builds still using version 1 url for application update checks

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P3)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Thunderbird is setting [1,2]
 pref("app.update.url", "https://aus2.mozilla.org/update/1/%PROD...
for the update query address. NB version 1 of the url format is being used. 

Meanwhile Firefox 3.0 is setting [3] 
 pref("app.update.url", "https://aus2.mozilla.org/update/3/%PROD...
ie version 3, which adds 
 .../%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/...

OS_VERSION is there so that we can avoid offering a Gecko 1.9.0 major-update to operating systems which are no longer supported (eg Windows 9x, Linux with old Gnome). The DISTRIBUTION stuff is for partner builds on not applicable to Thunderbird AFAIK.

I think Thunderbird 3.0 should use the version 3 url since the same major update issues apply as to Fx3; it might as well have the distribution on there too (makes no difference to the "vanilla" builds). 

It would be an excellent idea to check what else is out of sync, eg add-on update & blocklist checks.

[1] http://hg.mozilla.org/comm-central/index.cgi/file/23da5cab793a/mail/app/profile/all-thunderbird.js#l80 (for future releases)
[2] http://mxr.mozilla.org/seamonkey/source/mail/app/profile/all-thunderbird.js#80 (3.0a2)
[3] http://mxr.mozilla.org/seamonkey/source/browser/app/profile/firefox.js#113

Comment 1

[David Ascher (:davida)]

I'm not sure I get all the implications, but this seems important to get right from the start.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

This matches the update url to Firefox's version. I tried it locally on my Mac and it correctly picked up today's nightly.

The new fields are all automatic replacements, we don't need to add/change any other code.

Comment 3

[Mark Banner (:standard8)]

Checked in, changeset id 69:1177797ab880