448343 - Some "REFTEST TEST-UNEXPECTED-FAIL" not showing up in SeaMonkey Tinderbox brief log

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

Example with bug 448121:

<http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1217292654.1217297136.32761.gz&fulltext=1>
{{
MacOSX 10.4 comm-central dep unit test on 2008/07/28 17:50:54

REFTEST TEST-UNEXPECTED-FAIL |
file:///builds/slave/comm-central-macosx/build/mozilla/layout/reftests/border-image/multicolor-image-2.html
| 
REFTEST   IMAGE 1 (TEST): data:image/png;base64,[...]
REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,[...]
REFTEST number of differing pixels: -1
}}

<http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1217292654.1217297136.32761.gz>
Nowhere in the brief log :-(

Could this be fixed ?

Comment 1

[Serge Gautherie (:sgautherie)]

Could it be because there is no "error" keyword around ??

Comment 2

[(not currently active) Ted Mielczarek]

No, the unittest error parser knows to look for TEST-UNEXPECTED. Are these machines specifying the unittest error parser?
See http://hg.mozilla.org/build/buildbot-configs/index.cgi/file/edfd7a3f3604/mozilla2-unittest/master.cfg#l85

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Are these machines specifying the unittest error parser?
> See
> http://hg.mozilla.org/build/buildbot-configs/index.cgi/file/edfd7a3f3604/mozilla2-unittest/master.cfg#l85

I don't know how to search in this (Hg) repository...

From the cvs repository, it might seem they do:
http://mxr.mozilla.org/mozilla/search?string=errorparser%3D%22unittest%22&case=on&find=%2Ftools%2Fbuildbot-configs%2Ftesting%2F

But from the logs, it seems not, indeed:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1219394400.1219398996.7037.gz&fulltext=1
Linux mozilla-central qm-centos5-03 dep unit test on 2008/08/22 01:40:00
tinderbox: errorparser: unittest

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219401032.1219406377.30896.gz&fulltext=1
Linux comm-central dep unit test on 2008/08/22 03:30:32
tinderbox: errorparser: unix

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219402397.1219408184.22960.gz&fulltext=1
MacOSX 10.4 comm-central dep unit test on 2008/08/22 03:53:17
tinderbox: errorparser: unix

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219398766.1219405389.26960.gz&fulltext=1
Win2k3 comm-central dep unit test on 2008/08/22 02:52:46
tinderbox: errorparser: unix

Comment 4

[Robert Kaiser]

Fixed in http://hg.mozilla.org/build/buildbot-configs/index.cgi/rev/dbdb9e3d7c98 along with hg pull -u and reconfig on the master.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Fixed in

It seems there is an extra comma in your commit :-(

Comment 6

[Robert Kaiser]

the extra comma is intended, it makes it easier to add additional stuff later if needed

Comment 7

[Serge Gautherie (:sgautherie)]

V.Fixed : the brief log is so much better (and shorter) now :-)

Thanks me for the report, Ted for the hint, Robert for the fix ;-)

***

Precisely checked with bug 449533, which (report) appeared between

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219402397.1219408184.22960.gz
MacOSX 10.4 comm-central dep unit test on 2008/08/22 03:53:17
and
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219408294.1219414091.8394.gz
MacOSX 10.4 comm-central dep unit test on 2008/08/22 05:31:34

Generally confirmed with

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219408294.1219413279.5912.gz
Win2k3 comm-central dep unit test on 2008/08/22 05:31:34
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219413042.1219417973.20106.gz
Win2k3 comm-central dep unit test on 2008/08/22 06:50:42

and

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219408294.1219413701.7245.gz
Linux comm-central dep unit test on 2008/08/22 05:31:34
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219413460.1219418837.22395.gz
Linux comm-central dep unit test on 2008/08/22 06:57:40

Comment 8

[Serge Gautherie (:sgautherie)]

Mark, it seems Thunderbird boxes have this issue too:

For example, I checked:
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1219419520.1219420556.27569.gz
MacOSX 10.4 comm-central build on 2008/08/22 08:38:40
tinderbox: errorparser: unix

*****

Ted, I don't know if there are other people to teach about this parameter out there...

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #8)
> Mark, it seems Thunderbird boxes have this issue too:
> 
> For example, I checked:
> http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1219419520.1219420556.27569.gz
> MacOSX 10.4 comm-central build on 2008/08/22 08:38:40
> tinderbox: errorparser: unix

That's a build box not a unit test box. All Thunderbird's unit test boxes have the correct setting of unittest.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)

Arf, sorry, my bad :-(

Confirmed ok:
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1219425787.1219427132.15343.gz&fulltext=1
MacOSX 10.4 comm-central check on 2008/08/22 10:23:07
tinderbox: errorparser: unittest