448479 - No Proxy For: port Bug 311779 (save IE's ";" as "," so it works automatically)

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[benc]

Comment 1

[benc]

(whoops...)

LXR shows that this was implemented in FF and snuck by TB, probably because it was added to FF after the big-bang event that created the product modules:


http://mxr.mozilla.org/seamonkey/search?string=noProxiesPref.value.replace

noProxiesPref.value.replace

Searching... Pattern too long. Use a maximum 29 characters. No matching files Found one matching line Found 012345678901234567890123456789 matching lines in 012345678901234567890123456789 files Too many hits, displaying the first 1000
/browser/components/preferences/connection.js (View change log or blame annotations)

    * line 69 -- noProxiesPref.value = noProxiesPref.value.replace(/[;]/g,',');

/calendar/base/content/preferences/connection.js (View change log or blame annotations)

    * line 69 -- noProxiesPref.value = noProxiesPref.value.replace(/[;]/g,',');

(I'm assuming calendar was broken out off of Firefox...)

http://mxr.mozilla.org/seamonkey/find?text=&kind=text&string=connection.js

/browser/components/preferences/connection.js
/mail/components/preferences/connection.js
/extensions/irc/js/lib/connection.js
/storage/test/unit/test_storage_connection.js
/calendar/base/content/preferences/connection.js

(I'm going to assume /extensions/irc/ is chatzilla, but I'm not going to file there until someone gives me the nod...)

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 3

[Magnus Melin [:mkmelin]]

changeset:   508:7e48b0e640dc
http://hg.mozilla.org/comm-central/rev/7e48b0e640dc

->FIXED

Comment 4

[benc]

VERIFIED on: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081021 Shredder/3.0b1pre

Since this is in FF&TB, I'm going to mention it in the Proxy UI doc I've been working on:

http://developer.mozilla.org/En/Proxy_UI