No Proxy For: port Bug 311779 (map IE's ";" into ",") into "pref-proxies.js"

RESOLVED FIXED

Status

SeaMonkey
Preferences
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: benc, Assigned: ewong)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

9 years ago
No proxy for appears in:

/suite/common/pref/pref-proxies.js

In FF and Calendar, connection.js was modified to allow cut-and-paste IE no proxy configs to work auto-magically.
Version: unspecified → Trunk
This was just fixed for Thunderbird, too (bug 448479). SeaMonkey seems to take a more general approach for changing prefs, at least I couldn't find anything concerning actually changing prefs in pref-proxies.js. I guess oncommand and onChange, both used in pref-proxies.xul, are the wrong handlers for implementing this (the former fires on activating, the latter on changing an element).
(Assignee)

Comment 2

6 years ago
Created attachment 604046 [details] [diff] [review]
Port Bug 311779 : Map IE's ";" into ",".  (v1)
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #604046 - Flags: review?(iann_bugzilla)
Comment on attachment 604046 [details] [diff] [review]
Port Bug 311779 : Map IE's ";" into ",".  (v1)

Review of attachment 604046 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/common/pref/pref-proxies.js
@@ +218,5 @@
> +
> +function UpdateProxies()
> +{
> +  var noProxiesPref = document.getElementById("network.proxy.no_proxies_on");
> +  noProxiesPref.value = noProxiesPref.value.replace(/[;]/g,',');

Nit: I think this can/should be
  .replace(/;/g, ",");
(the brackets are unnecessary, we usually have a space after a comma, and use double quotes).
(Assignee)

Comment 4

6 years ago
Created attachment 604372 [details] [diff] [review]
Port Bug 311779 : Map IE's ";" into ",".  (v2)

Fixed nit from comment #3.
Attachment #604046 - Attachment is obsolete: true
Attachment #604372 - Flags: review?(iann_bugzilla)
Attachment #604046 - Flags: review?(iann_bugzilla)
Comment on attachment 604372 [details] [diff] [review]
Port Bug 311779 : Map IE's ";" into ",".  (v2)

Review of attachment 604372 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/common/pref/pref-proxies.js
@@ +218,5 @@
> +
> +function UpdateProxies()
> +{
> +  var noProxiesPref = document.getElementById("network.proxy.no_proxies_on");
> +  noProxiesPref.value = noProxiesPref.value.replace(/;/g,', ');

Sorry for confusing you. I meant space after a comma /in code/, not /in a string/. ;-) See my example, which you could/should have copied 1:1.
(Assignee)

Comment 6

6 years ago
Created attachment 604824 [details] [diff] [review]
Port |Bug 311779 (map IE's ";" into ",")| (v3)
Attachment #604372 - Attachment is obsolete: true
Attachment #604824 - Flags: review?(iann_bugzilla)
Attachment #604372 - Flags: review?(iann_bugzilla)

Updated

6 years ago
Attachment #604824 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 7

6 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/5df4e53682a2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.