448551 - The Target Milestone field should have the same maximum length as the Version field

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Eiren Smith]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: 

I frequently want to make matching Version and Target Milestone entries, whereupon I run into a 20-character limit on Milestone names. Version entries allow more characters than this.

Reproducible: Always

Steps to Reproduce:
1. Try to create a Milestone with e.g. 21 characters in its name.
2. Try to create a Version with e.g. 30 characters in its name.
Actual Results:  
It is possible to create the 30-char Version entry but not the 21-char Milestone entry.

Expected Results:  
I would expect Version and Milestone entries to have the same character length limit as each other (by making Milestone longer, not by making Version shorter.)

I searched for this in bmo and didn't find any previous request for it. Maybe my terminology is off.

Comment 1

[Frédéric Buclin]

Yeah, makes sense.

Comment 2

[Frédéric Buclin]

That's actually a DB problem:

milestones.value has varchar(20) while versions.value has varchar(64).

Comment 3

[Jeff]

I think the change I've proposed in bug#467711 may also help workaround this issue for many users who really need an extra field for an expanded description for milestones.

Comment 4

[Eiren Smith]

Beyond voting and this comment, how do I nudge this in a polite way to gently bring attention to it?

Comment 5

[Max Kanat-Alexander]

Eiren: You can always try to come into IRC and convince somebody to work on it. :-) http://wiki.mozilla.org/Bugzilla:Communicate

Comment 6

[Frédéric Buclin]

Attachment: WIP, v0.1

This patch fixes the DB schema (untested; not sure if the indexes must be rebuilt), because eirens asked so kindly on IRC. :) But I don't have the time nor the motivation to convert all the 'size="20" maxlength="20"' to 'size="64" maxlength="64"' in the various templates, and to make sure that everything is still working fine. But it shouldn't be too hard for someone to continue from here.

Comment 7

[Gervase Markham [:gerv]]

Attachment: Patch v.1

I just hit this; let's fix it :-) I think I've probably got all the places you can type in a target milestone. (I think perhaps the one in edit-common.html will never get hit, because there's always at least one milestone, but I updated it anyway.)

Gerv

Comment 8

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Turns out there's a constant as well.

Gerv

Comment 9

[Gervase Markham [:gerv]]

Attachment: Patch v.3

Turns out there is some old checksetup.pl code which switches the database column sizes back again! This version of the patch removes it.

Last one, I hope...

Gerv

Comment 10

[Frédéric Buclin]

Comment on attachment 602843 [details] [diff] [review]
Patch v.3

>=== modified file 'Bugzilla/Install/DB.pm'

>+    # 2010-11-30 [e-mail] - Bug 448551

Fix the date to match the current date. r=LpSolit with this fix on checkin.

Comment 11

[Gervase Markham [:gerv]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified template/en/default/admin/products/edit-common.html.tmpl
modified template/en/default/admin/milestones/edit.html.tmpl
modified Bugzilla/DB/Schema.pm
modified Bugzilla/Constants.pm
modified Bugzilla/Install/DB.pm
modified template/en/default/admin/milestones/create.html.tmpl
Committed revision 8163.

Gerv

Comment 12

[Frédéric Buclin]

Added to relnotes for 4.4.