Closed
Bug 448609
Opened 16 years ago
Closed 15 years ago
Quicksearch should search classification
Categories
(Bugzilla :: Query/Bug List, enhancement)
Tracking
()
RESOLVED
DUPLICATE
of bug 518024
People
(Reporter: jjclark1982, Assigned: reed)
References
Details
Attachments
(1 file, 2 obsolete files)
7.80 KB,
patch
|
Details | Diff | Splinter Review |
At NASA we moved a grouping from the Product level to the Classification level and users expected to be able to use the quicksearch ":" operator to search Classification. This patch adds that functionality to the ":" operator if the "useclassification" param is turned on. It will also need documentation.
Attachment #331807 -
Flags: review?
Comment 1•16 years ago
|
||
Comment on attachment 331807 [details] [diff] [review] v1 This makes a lot of sense to me; r=Wurblzap by inspection.
Attachment #331807 -
Flags: review? → review+
Updated•16 years ago
|
Severity: normal → enhancement
Flags: approval?
OS: Mac OS X → All
Hardware: Macintosh → All
Target Milestone: --- → Bugzilla 3.4
Comment 2•16 years ago
|
||
I want the doc at page.cgi?id=quicksearchhack.html and page.cgi?id=quicksearch.html to be fixed too before approving it.
Flags: approval?
Comment 3•16 years ago
|
||
Jesse, are you willing to add the additional fixes, and upload a new patch?
Reporter | ||
Comment 4•16 years ago
|
||
Added documentation.
Attachment #331807 -
Attachment is obsolete: true
Attachment #344965 -
Flags: review?(LpSolit)
Comment 5•16 years ago
|
||
Comment on attachment 344965 [details] [diff] [review] v2 >Index: template/en/default/pages/quicksearchhack.html.tmpl >=================================================================== >+ <td><tt>classification</tt></td> You added classification as a field name to documentation but search with this field name doesn't work. You should also add support for "classification:searchword" syntax and possibly even class or clas aliases for it (remember to document these aliases in this page if added). This is a simple addition to MAPPINS constant at around line 64 and can be done before checkin or in an updated patch so I'll grant a review anyway.
Attachment #344965 -
Flags: review?(LpSolit) → review+
Updated•16 years ago
|
Flags: approval?
Comment 6•16 years ago
|
||
I first want to see an updated patch. In comment 5, you say that searching with classification doesn't work.
Flags: approval?
Comment 7•15 years ago
|
||
Comment on attachment 344965 [details] [diff] [review] v2 Changing my mind per LpSolit and my previous review comment.
Attachment #344965 -
Flags: review+ → review-
Assignee | ||
Comment 9•15 years ago
|
||
Ok, how about this? It is untested...
Assignee: jjclark1982 → reed
Attachment #344965 -
Attachment is obsolete: true
Attachment #411374 -
Flags: review?(mkanat)
Comment 10•15 years ago
|
||
This will in fact be resolved by bug 518024.
Updated•15 years ago
|
Attachment #411374 -
Flags: review?(mkanat)
Updated•15 years ago
|
Whiteboard: [needs new patch]
Target Milestone: Bugzilla 4.0 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•