Created attachment 331807 [details] [diff] [review] v1 At NASA we moved a grouping from the Product level to the Classification level and users expected to be able to use the quicksearch ":" operator to search Classification. This patch adds that functionality to the ":" operator if the "useclassification" param is turned on. It will also need documentation.
Attachment #331807 - Flags: review?
Comment on attachment 331807 [details] [diff] [review] v1 This makes a lot of sense to me; r=Wurblzap by inspection.
Attachment #331807 - Flags: review? → review+
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: Macintosh → All
Target Milestone: --- → Bugzilla 3.4
I want the doc at page.cgi?id=quicksearchhack.html and page.cgi?id=quicksearch.html to be fixed too before approving it.
Jesse, are you willing to add the additional fixes, and upload a new patch?
Created attachment 344965 [details] [diff] [review] v2 Added documentation.
Comment on attachment 344965 [details] [diff] [review] v2 >Index: template/en/default/pages/quicksearchhack.html.tmpl >=================================================================== >+ <td><tt>classification</tt></td> You added classification as a field name to documentation but search with this field name doesn't work. You should also add support for "classification:searchword" syntax and possibly even class or clas aliases for it (remember to document these aliases in this page if added). This is a simple addition to MAPPINS constant at around line 64 and can be done before checkin or in an updated patch so I'll grant a review anyway.
Attachment #344965 - Flags: review?(LpSolit) → review+
I first want to see an updated patch. In comment 5, you say that searching with classification doesn't work.
Comment on attachment 344965 [details] [diff] [review] v2 Changing my mind per LpSolit and my previous review comment.
Attachment #344965 - Flags: review+ → review-
too late for 3.4.
Target Milestone: Bugzilla 3.4 → Bugzilla 4.0
Created attachment 411374 [details] [diff] [review] patch - v3 Ok, how about this? It is untested...
This will in fact be resolved by bug 518024.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Depends on: 518293
Resolution: --- → DUPLICATE
Duplicate of bug: 518024
Whiteboard: [needs new patch]
Target Milestone: Bugzilla 4.0 → ---
You need to log in before you can comment on or make changes to this bug.