Closed
Bug 518024
Opened 15 years ago
Closed 15 years ago
Make quicksearch accept any field name or any unique starting substring of a fieldname
Categories
(Bugzilla :: Query/Bug List, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: mkanat, Assigned: mkanat)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
12.37 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Right now QuickSearch has a bunch of custom stuff in a "MAPPINGS" constant that allows shortcuts and various names for fields in the bugs table. Instead of that, we should allow any field to be used that can be searched on, and we should allow any starting substring of any field name to be used, as long as it uniquely matches that field. (For example, "key:" would match "keywords:" uniquely.)
Comment 1•15 years ago
|
||
We should still accept shortcuts like kw or sw.
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > We should still accept shortcuts like kw or sw. Yeah, I intend to retain backwards-compatibility for things like that, unless there's some really good reason not to do so.
Assignee | ||
Comment 3•15 years ago
|
||
Okay, here we go! This is actually pretty cool! :-) It does pretty much exactly what I said in comment 0. It removes the "owner:" shortcut for "assigned_to", because the code marked that as deprecated and it's been a while since that deprecation was put there.
Assignee: query-and-buglist → mkanat
Status: NEW → ASSIGNED
Attachment #402277 -
Flags: review?(wicked)
Attachment #402277 -
Flags: review?(dkl)
Assignee | ||
Comment 4•15 years ago
|
||
Comment on attachment 402277 [details] [diff] [review] v1 Oh wait, I still need to update the documentation.
Attachment #402277 -
Attachment is obsolete: true
Attachment #402277 -
Flags: review?(wicked)
Attachment #402277 -
Flags: review?(dkl)
Assignee | ||
Updated•15 years ago
|
Attachment #402277 -
Flags: review?(wicked)
Attachment #402277 -
Flags: review?(dkl)
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 402277 [details] [diff] [review] v1 Okay, nevermind. I'm going to fix the documentation in another bug.
Assignee | ||
Updated•15 years ago
|
Priority: -- → P1
Assignee | ||
Updated•15 years ago
|
Attachment #402277 -
Flags: review?(dkl) → review?(LpSolit)
Updated•15 years ago
|
Attachment #402277 -
Attachment is obsolete: false
Comment 7•15 years ago
|
||
Comment on attachment 402277 [details] [diff] [review] v1 Everything looks good except that typing bug:lp crashes Bugzilla: DBD::Pg::st execute failed: ERROR: unknown fonction lower(integer) LINE 1: ...','UNCONFIRMED') )) AND ((POSITION(LOWER('lp') IN LOWER(bugs...
Attachment #402277 -
Flags: review?(wicked)
Attachment #402277 -
Flags: review?(LpSolit)
Attachment #402277 -
Flags: review-
Assignee | ||
Comment 8•15 years ago
|
||
What version of Pg are you using? I can't reproduce that error.
Assignee | ||
Comment 9•15 years ago
|
||
Comment on attachment 402277 [details] [diff] [review] v1 That's a bug in Search.pm, even if it is reproducible. The same thing would happen if you did a "contains the string" search on the bug_id field and typed a string. In any case, the input is indeed invalid, so I'm not so opposed to the whole idea of it crashing.
Attachment #402277 -
Flags: review- → review?(LpSolit)
Comment 10•15 years ago
|
||
(In reply to comment #8) > What version of Pg are you using? I can't reproduce that error. I have Pg 8.3.8.
Comment 11•15 years ago
|
||
Comment on attachment 402277 [details] [diff] [review] v1 r=LpSolit
Attachment #402277 -
Flags: review?(LpSolit) → review+
Updated•15 years ago
|
Flags: approval+
Assignee | ||
Comment 12•15 years ago
|
||
Checking in Bugzilla/Search/Quicksearch.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v <-- Quicksearch.pm new revision: 1.27; previous revision: 1.26 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.290; previous revision: 1.289 done
You need to log in
before you can comment on or make changes to this bug.
Description
•