448886 - Unable to edit event: comes up with attendee confirmation

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Laurens]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: 0.9pre 31-jul-2008 20:15 PST

After trying to edit an event, I'm stuck with some windows about confirming your attendance to the event, while I was actually expecting the usual edit dialog.

Reproducible: Sometimes

Steps to Reproduce:
1.Double click on any item in the calendar, or right click and choose Open
2.Try to edit the item details.

Actual Results:  
When double clicking or choosing Open from the context menu, instead of being able to edit the event details, I'm getting a window to confirm all attendees to this event. For most events, only my own name / e-mail is listed, but I can in no way get to edit the actual event details. Not happening to every item, but sure does to a lot of them!

Expected Results:  
I was expecting the usual event dialog with all event info filled in to be editted.

Tested with thunderbird 2.0.0.16. Reproducable...

Comment 1

[Stefan Sitter [:ssitter]]

This looks like the dialog that is shown if your calendar is set to read-only. I'd recommend to check the calendar properties and remove the read-only flag if necessary.

Comment 2

[Laurens]

Checked; none of the calendars are read-only nor are they on a shared device which could render it somehow read-only. They are just plain local calendars. It is also not happening to every item but only to some of them - although I cannot find any pattern in it. Actually, I can; reoccurring items do not suffer this problem; they give me another dialog about editting only this occurance or every occurance; then I'm transfered succesfully to the edit dialog.
But for normal items, this often just gives me the dialog about attendance (see url for example)

Comment 3

[Bas van den Bosch]

Confirmed, This happenend to me when I invited myself to an event (for testing), maybe it happens only to events on which one receives an update? 

Comment 4

[Pete Riley]

Attachment: OP's screenshot of event dialog when you're not the meeting organizer

I think this is the dialog that you see when you're not the organizer of the meeting.  I think that Laurens will see the normal event dialog if the organizer of the event matches the default organizer in the calendar's properties.

I guess the purpose is that you're not allowed to edit meeting events that are sent by other organizers.  You can only change the things that you see in this new dialog.

Comment 5

[Laurens]

That could be the problem I guess. I'm synchronizing events with the SyncKolab add-in for Thunderbird, and I might be well possible that lightning makes a comparison on some kind of UID, which would be different on my normal pc from that on my laptop. Is there a way to do comparison on eg. the e-mail address, so it is still possible to edit my own events?

Secondly, regarding your comment, I think it is definately thinkable and wanted to be able to edit other / outside events! Having accepted them doesn't mean you don't want to add more details to it, eg. make notes or add a specific address...

Comment 6

[Pete Riley]

(In reply to comment #5)
> [...] possible that lightning makes a
> comparison on some kind of UID,
As far as I can tell, Lightning compares email addresses (not User IDs), so you should be okay as long as you use the same Thunderbird identity on both computers (in the corresponding calendars' properties).

> I think it is definately thinkable and wanted
> to be able to edit other / outside events!
Agreed.  I was disappointed when I discovered that we can no longer do this.

Comment 7

[Laurens]

(In reply to comment #6)

> As far as I can tell, Lightning compares email addresses (not User IDs), so you
> should be okay as long as you use the same Thunderbird identity on both
> computers (in the corresponding calendars' properties).

I verified and both profiles have the same email-adres, even if compared case-sensitive. They are (logically) not the same profile though; I created a new profile and IMAP account on the laptop. Calendar names differ though...but it wouldn't be right (i think) if that'd be a problem. Maybe its not about not being the owner of the event?

Comment 8

[Laurens]

Edit: I just checked and can verify that items which I cannot edit on laptop, can be edited on workstation, so it seems indeed a problem of where the event has been created...

Comment 9

[Pete Riley]

I don't think that the name of the calendar matters, nor whether the account is IMAP, POP3, etc.  Only the identity.  An identity looks like this:  "Laurens <[e-mail]>".  In particular, only the email address in the identity matters, at least in my tests.

I would follow these steps:

On the workstation:
1) Switch to calendar mode (e.g. month view)

2) In the list of calendars on the left side, double click the name of the calendar

3) You should see "E-mail".  The drop-down box after that should show all of the Thunderbird identities that you have on your workstation.

4) Write down which identity is selected.  It should be something like "Laurens <[e-mail]>".  This is probably the organizer of the event.  Maybe not for events that you created in the past, but probably for events that you'll create in the future.

On the laptop:
1) Repeat steps (1) through (3) from above.
2) Select the same identity for this laptop that you saw when you were on the workstation.

If you don't see the same identity on the laptop, then you can add it to the laptop by using the Thunderbird menu:  "Tools > Account Settings > 'YourEmailAccountName' > Manage Identities".

If this information doesn't solve the problem then it would probably be better to continue the discussion in the newsgroup or in the Calendar forum at http://forums.mozillazine.org.

Comment 10

[Pete Riley]

p.s. You probably also have to install a recent version of the Lightning nightlies on both computers.

Comment 11

[Daniel Boelzle [:dbo]]

I can imagine the problem is that calProviderBase.js' itip invitation handling doesn't check the configured email against the ORGANIZER; I should fix that.

Comment 12

[Daniel Boelzle [:dbo]]

(In reply to comment #3)
> Confirmed, This happenend to me when I invited myself to an event (for
> testing), maybe it happens only to events on which one receives an update? 

I had a look at the code, and it seems it works correctly. Inviting myself (without sending iMIP though) works for me -- I still get the read-write dialog. Bas, could you please add detailed STR here?

Comment 13

[Daniel Boelzle [:dbo]]

(In reply to comment #6)
...
> > I think it is definately thinkable and wanted
> > to be able to edit other / outside events!
> Agreed.  I was disappointed when I discovered that we can no longer do this.

Yes, I'd like that, too. The problem is that the current read-write dialog isn't suitable for changing participation status, and allows attendees to modify the time slot. I can imagine we extend it in the future to implement iTIP COUNTER, e.g. if the user drags an event to another day (or performs other significant changes using the read-write dialog), an iTIP COUNTER is sent out to the organizer.

Comment 14

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

I got it now; core problem seems to be the dataloss of ORGANIZER in storage (bug 348264). The attached patch streamlines the invitation handling a bit, fixes isInvitation vs. getInvitedAttendee (+ documentation).

Comment 15

[Laurens]

Excuse my ignorance, but will this mean it'll be in the next nightly build? Not sure how to apply the patch (i'm not developing or running from source)...

Comment 16

[Daniel Boelzle [:dbo]]

No, the patch needs to be reviewed first. Once that's done, I'll check it in, and it's in the following nightlies.

Comment 17

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 332249 [details] [diff] [review]
fix - v1

Looks good, r=philipp

Comment 18

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.