Closed Bug 348264 Opened 18 years ago Closed 16 years ago

ORGANIZER property lost after import + export

Categories

(Calendar :: Provider: Local Storage, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: dbo)

References

Details

(Keywords: dataloss)

Attachments

(2 files)

ORGANIZER property lost after doing import + export to storage calendar

Steps to Reproduce:
1. Create local storage calendar.
2. Import ics file that contains an event with ORGANIZER property
   into that storage calendar.
3. Export event as new iCalendar file from storage calendar.
4. Compare both ics files.

Actual Results:
ORGANIZER property disappeared.

Expected Results:
ORGANIZER property is kept.

Additional Information:
Works with ics provider (Fixed with Bug 322859).

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060810 Calendar/0.3a2+
Attached file testcase —
Calendar that contains one event with ORGANIZER property.
As this is internal dataloss, this should probably block the release.
Flags: blocking0.3?
(Note: See also Bug 322859 Comment #7 and following comments on that topic.)
(In reply to comment #2)
> As this is internal dataloss, this should probably block the release.
> 
This isn't internal dataloss.  Internal dataloss applies to changes made within the program being preserved in the program.  Since we don't offer any way to create an organizer, this can't be internal.
Not a blocker.  It's impossible to keep perfect data integrity after import+export.  If users are intending to continue to share their data with foreign clients, they shouldn't be importing it (since those clients likely can't read our sqlite).  I'll also say that it's unlikely we'll accept a patch here, since it would probably involved a rev of the sqlite schema.  If it were possible to solve this bug without such a rev, then we'll consider it.
Flags: blocking0.3? → blocking0.3-
(In reply to comment #5)
> I'll also say that it's unlikely we'll accept a patch here, since it would
> probably involved a rev of the sqlite schema.

I've added organizer to the proposed schema in bug 333688.
When that lands, this will be fixable.

Depends on: 333688
Keywords: dataloss
Hardware: PC → All
Target Milestone: --- → Sunbird 0.5
Whiteboard: swag: .5d
No longer depends on: 333688
Not going to make the 0.5 train.
Target Milestone: Sunbird 0.5 → ---
Attached patch fix — — Splinter Review
fix + untabification

We should really consider to store items as serialized ical strings with some more tables/columns for querying. Modifying the schema again and again is really annoying...
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #332247 - Flags: review?(philipp)
Flags: blocking-calendar0.9+
Blocks: 448886
Flags: in-testsuite?
Whiteboard: swag: .5d
Version: Trunk → unspecified
Comment on attachment 332247 [details] [diff] [review]
fix

Looks good, r=philipp
Attachment #332247 - Flags: review?(philipp) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Checked with lightning 2008080703 and sunbird 20080806 -> VERIFIED

To get a correct result file a application restart between *.ics-file import and ics-file export is necessary.
Status: RESOLVED → VERIFIED
... being more precise: to reproduce the bug description on 0.8, you have to restart, because otherwise the memory cached items are properly exported (storage has a memory cache since 0.8).
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: