448939 - XULBrowserWindow cleanup

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

- remove nsBrowserStatusHandler
- use smart getters
- stop setting the level attribute on the urlbar (made obsolete in Fx3)
- show / hide the security button in app code rather than in the themes

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> - use smart getters

except for elements that can be added / removed by customizing the toolbars
(i.e.: except for the throbber)

Comment 2

[Asaf Romano (gone)]

Comment on attachment 332113 [details] [diff] [review]
patch

r=mano

Comment 3

[Dão Gottwald [:dao]]

pushed as changeset 18939:e6b88d928273

Comment 4

[Wladimir Palant]

This caused a bug in browser.js:

          let location = aRequest.URI;

This was previously declared with the "var" keyword and is used outside the block. Now |if (!msg && (!location || location.spec != "about:blank"))| doesn't have this variable in scope any more and gets window.location instead. Hence the warning "reference to undefined property location.spec".

Comment 5

[Wladimir Palant]

Note that the patch that was checked in was quite a bit more extensive than the one attached (and reviewed) here...

Comment 6

[Dão Gottwald [:dao]]

Yeah, that one didn't apply anymore -- my local up-to-date patch contained more drive-by cleanup.

Comment 7

[Frank Lion]

Dao,

We need the urlbar level attribute back. At a time with Google Chrome breathing down our necks, we need to be giving users more choice, not less. Many users want a yellow urlbar for the https state.

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> Many users want a yellow urlbar for the https state.

Something like this should work:

#identity-box.verifiedDomain + .textbox-input-box ,
#identity-box.verifiedDomain ~ #urlbar-icons {
  background: ...;
}