Closed
Bug 454526
Opened 17 years ago
Closed 17 years ago
browser.js' onStateChange() code references variable that's no longer in scope.
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.1b1
People
(Reporter: jst, Assigned: dao)
References
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
Gavin
:
review+
jwkbugzilla
:
review+
|
Details | Diff | Splinter Review |
I didn't actually look at what this code really tries to do, but the code at:
http://hg.mozilla.org/mozilla-central/annotate/22805910408e/browser/base/content/browser.js#l3918
seems to be refering to the "location" variable declared at:
http://hg.mozilla.org/mozilla-central/annotate/22805910408e/browser/base/content/browser.js#l3897
but at that point the location variable is no longer in scope.
Not sure how severe this is, but nominating so that someone who knows this code can decide.
Flags: blocking-firefox3.1?
|
Assignee | |
Comment 2•17 years ago
|
||
|
||
Comment 3•17 years ago
|
||
Comment on attachment 339419 [details] [diff] [review]
patch
That patch is fine though I would initialize location with null.
Attachment #339419 -
Flags: review+
|
||
Updated•17 years ago
|
Attachment #339419 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•17 years ago
|
||
(In reply to comment #3)
> I would initialize location with null.
Wouldn't make a difference, right?
pushed 19441:fdbf5df7bbef
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
|
||
Updated•17 years ago
|
Flags: blocking-firefox3.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•