448989 - Merge mozilla-qt branch into mozilla-central

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: QtPort enabler. Diff for existing files

Mozilla qt
http://hg.mozilla.org/users/vladimir_mozilla.com/index.cgi/mozilla-qt
port need to be merged into mozilla-central.

See QtPort enabler patch for existing sources.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: List of new files required for QT port

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Full patch for Qt port

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 332155 [details] [diff] [review]
QtPort enabler. Diff for existing files

This patch looks fine, are these really the only changes to existing files?  I would've expected changes in nsObjectFrame at least, or are we building with --disable-plugins?

Comment 4

[Oleg Romashin (:romaxa)]

> would've expected changes in nsObjectFrame at least, or are we building with

We are building with enable-plugins, but actually they are still broken (plugin port not implemented properly).

I hope it will be fixed soon.

Comment 5

[bugzilla.mozilla.org]

Awesome work. Having a nice integration between KDE and firefox would be amazing !

Comment 6

[Oleg Romashin (:romaxa)]

vlad, what is the best way to land this patch?
Commit  "Full patch for Qt port" in one iteration, or commit first patch and push new files after that?

Comment 7

[Luke-Jr]

Attachment: Patch against Firefox 3.0.1

Comment 8

[Luke-Jr]

Attachment: Patch against XULRunner 1.9.0.1

Comment 9

[Luke-Jr]

Note, I didn't change anything, just made the patches apply cleanly and separately to XULRunner and Firefox.

Comment 10

[Luke-Jr]

Oh well, I couldn't get it to work. :(

Comment 11

[Oleg Romashin (:romaxa)]

Attachment: nsObjectFrame part of qt port

Comment 12

[Oleg Romashin (:romaxa)]

Attachment: Diff for existing files, updated to trunk + nsObjectFrame

DFB has been landed to trunk, therefore created new diff, updated to trunk.
Also added nsObjectFrame fixes.

Comment 13

[Oleg Romashin (:romaxa)]

Attachment: Full version of latest trunk Qt port.

Comment 14

[Luke-Jr]

Will this work with 3.0.1?

Comment 15

[Oleg Romashin (:romaxa)]

I think no.

Comment 16

[Oleg Romashin (:romaxa)]

Stuart can you help me with merging Qt branch into mozilla-central?
Do we need to do anything else? Or can you just land that patch? or someone else can do that?

Comment 17

[Oleg Romashin (:romaxa)]

Attachment: Old Embedding API remove

Comment 18

[Yuri Gagarin]

That last patch breaks the qt build (from mozilla-central) for me. It complains with:

gmake[4]: *** No rule to make target `/home/sigma/Develop/Repos/hg/mozilla-central/embedding/browser/qt/tests/Makefile.in', needed by `embedding/browser/qt/tests/Makefile'.  Stop.

Can someone please update the mozconfig at https://wiki.mozilla.org/User:Pjohnsen/MozillaQtBuild to a working configuration?

Comment 19

[Oleg Romashin (:romaxa)]

> needed by `embedding/browser/qt/tests/Makefile'.  Stop.
It is just a bug 450936....

Comment 20

[Mike]

Please add this Qt Instant Messenger
http://retromessenger.sf.net -> Layout
http://retroshare.sf.net -> qt gui and library
https://bugzilla.mozilla.org/show_bug.cgi?id=451565 

Comment 21

[misha slavin]

Attachment: screenshot of latest firefox-qt build

Screenshot of latest firefox-qt build in kde 4. Looks really bad for me, even worse than using regular firefox in kde4.

Comment 22

[Ramon Antonio Parada]

#21 That's because of your theme version is not compatible with your Firefox version. You must deactivate version checking for extensions. Explanation here: http://articles.bluishcoder.co.nz/article/disable-firefox-extension-version-checking/

Appearence still won't be perfect. This is not official but I'm working to make KFirefox fully compatible with it. http://ramonantonio.net/kde-firefox/




I had still no time to report properly some bugs. Here it's what I was investigating:

1. Doubeclick doesn't work in search bar. Doubleclick seems to be correctly launched at widget/src/qt/nsWindow.cpp   nsWindow::mouseDoubleClickEvent but I don't get expected behaviour: getting all text at searchbar selected.

2. Some key events are launched but do not work properly. Those in the class of FunctionKey + ASCIIKey (Ctrl+T for example) do not work properly.

Comment 23

[Yuri Gagarin]

(In reply to comment #22)
> #21 That's because of your theme version is not compatible with your Firefox
> version. You must deactivate version checking for extensions.

Sorry, you're mistaken. What the screenshot in Comment #21 shows is exactly how firefox-qt looks by default, with *no* add-ons/themes. Compile it, move your current ~/.mozilla dir somewhere else, then launch it and you'll see.

Comment 24

[u294409]

don't expect pixel-perfect look from so young port... if you help with bugs - you can expect it faster ;) .

Comment 25

[Mats Ahlgren]

I've been looking forward to this so much! Previous the use of the GTK theme on KDE unfortunately made Firefox really unusable unless I hacked it severely (black text on black buttons, gray text on dark menus, etc. -- very, very unfriendly to dark color schemes).

However when I tried to run Firefox-qt, I got the following error when using the x86 build.

% ./firefox
./firefox-bin: symbol lookup error: ./libxul.so: undefined symbol: _ZN6QEvent17registerEventTypeEi

Running Suse 10.3, 64-bit processor.

Is a specific version of Qt required? (e.g. 4.??, as perhaps implied by the build instructions)? I ran some random qt* command (qtdoc) and it seems to imply that I have Qt 3.3.8.

Comment 26

[Shriramana Sharma]

Hello people! I'm really interested in using Firefox on Qt/KDE, but the last comment on this bug is almost a year old and this bug is closed "RESOLVED FIXED". If it is fixed then why do we not see a publicly released Qt port of Firefox? 

Are there any issues pending for the Qt port, or has support for this port been dropped? I would like a clarification from the developers on just how far the Qt port has progressed and what the ETA of public binary builds of the Qt port is.

Thanks.

Comment 27

[skierpage]

It seems (In reply to comment #26)
> this bug is closed "RESOLVED FIXED".

... because the Qt back-end is now part of the Mozilla toolkit source tree.  Whether Firefox or other Mozilla products are built for Qt or KDE is separate from this bug (it appears the Fennec mobile browser on Maemo can target a Qt backend).  FWIW I filed bug 543912 that http://www.mozilla.org/ports/qtmozilla/ is out-of-date.