449158 - Omnibus ad-blocking bug for August/September 2008

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Once upon an ad…

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://soccernet.espn.go.com/columns/story?id=559409&sec=us&root=us&&cc=9999

div[id="google_textadsBox"]

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I didn't have time tonight to dig in, but Mapquest has a bunch of unblocked ads to zap this go-round.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On various http://blog.zap2it.com/ pages, 

div[id="wide-text-ads"]

August was a barn-burner; let's see what September holds.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://money.howstuffworks.com/personal-finance/financial-planning/money-market-accounts2.htm

div[class="google-ads"] (* is probably safe here)
div[class="ads"]
div[class="relatedAds"]
div[class="ad module"] (~ might be safe here)
div[class="adGoogle1"] (^ probably safe here)

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.imdb.com/name/nm0001629/ (and probably elsewhere on imdb)

embed src=http://hs.interpolls.com/w/SATC5308/ipoll_ad.swf? etc.

Comment 6

[Chris Lawson (gone)]

Lots of Pulse 360 ads showing up on Freep.com all of a sudden.

http://www.freep.com/apps/pbcs.dll/article?AID=/20080922/BUSINESS07/809220366/

is an example page.

http://content.pulse360.com/cgi-bin/context.cgi?id=91041742&ganid=freep&gans=&ganss=&gant=&ganst=&format=bare&title=1&signup=1

is the generating script, and pretty much all the ad divs seem to have "p360" in them somewhere.

cl

Comment 7

[Lars Frers]

This German-English / -Spanish / -French / -Italian / -Chinese translation website has ads all over it:

http://dict.leo.org/

Most of the ads seem to be coming from (not sure if all though):

http://advert.leo.org/

(The site is used by practically everyone that I know in Germany and I think it is even part of the default search thingies that are delivered with German Firefox (yes, I know this one here is about Camino!) builds.)

Comment 8

[philippe (part-time)]

Seen on armytimes.com, (random) flash banners with a src points to aka-cdn-ns.adtechus.com.
We already block images from adtechus.com

example url
http://www.armytimes.com/news/2008/09/army_homeland_090708w/
(took several reloads to get them to re-appear)


(In reply to comment #7)
 
> Most of the ads seem to be coming from (not sure if all though):
> 
> http://advert.leo.org/
all those ad-links point to advert.leo.org which appears to be their redirect server.

Comment 9

[philippe (part-time)]

On MacNN, in the right-most column
http://www.macnn.com/articles/08/10/01/apple.on.mac.pro.toxins/

<script src="http://adopt.euroclick.com/adopt.eu?l=e2d62ad4&sz=160x600&r=j&rnd=" language="JavaScript">
</script>
<a target="_blank" href="http://adopt.euroclick.com/lnk/?k=MTQ0NTQ7OTc3MTs5MDAyOzQyNzUzO2YuZi45LnFrLjU5LmZAQHlpbHp3eXptd0BAdWZwZmxwekBAMF85QEB6aHpzciBtdmc7MTIyMjkyNTUzNzIxODsxOzsxMTgxfDs7MDszNTUwODkyOzE=href=http://www.anrdoezrs.net/click-1672493-10504397?SID=36308C4CA18A1EDA9-14454-9771-9002-42753-1-jp-2">
<img width="160" height="600" border="0" src="http://www.awltovhc.com/image-1672493-10504397" alt="Click Here!"/>
</a>

(amusingly, http://euroclick.com/ redirects to http://www.adconion.com/)

Comment 10

[sairuh (rarely reading bugmail)]

From the Top Webcomics voting page, Flash ads from splastk.com. To view, load http://topwebcomics.com/vote/2527/default.aspx --an example ad comes from the following url:

http://www.splastk.com/syndicated/topwebcomics/SplastkPlayer_v2.2.swf?rand=0.6572527368066331&video_xml_url=http://www.splastk.com/syndicated/topwebcomics/video_xml.xml?rand=0.17342995113994608

Comment 11

[sairuh (rarely reading bugmail)]

A couple more Flash ads from yieldmanager.net and edgesuite.net. For example:

http://l.yieldmanager.net/apex/mediastore/8b1aa6c2-ac81-423d-be88-f9418d4b4db7

    http://c6.edgesuite.net/RealMedia/ads/Creatives/SFGate/macys_columbus_day_fixed_APT/macysClmbs_300x250.swf/1223426362?clickTAG1=http://oascentral.sfgate.com/RealMedia/ads/click_lx.ads/www.sfgate.com/tmp/chris/macys2/L31/1043952027/Middle1/SFGate/macys_columbus_day_fixed_APT/macys_columbus_day_fixed_APT_square.html/524c635a4530687a3348734142426679?http://www.sfgate.com/place-ads/macys/&clickTAG2=http://oascentral.sfgate.com/RealMedia/ads/click_lx.ads/www.sfgate.com/tmp/chris/macys2/L31/1043952027/Middle1/SFGate/macys_columbus_day_fixed_APT/macys_columbus_day_fixed_APT_square.html/524c635a4530687a3348734142426679?http://akimages.crossmediaservices.com/listingimages/Retailers/macys/Coupons/MW_CDS_10_8_Coupon.pdf?PartnerID=SFGATE&BannerID=x132

I had seen these at the following SF Gate article:

http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/10/07/FDGP133N8V.DTL

Comment 12

[sairuh (rarely reading bugmail)]

...And annoying ones in an iframe from condenet.com, such as the banner in this Ars Technica article:

http://arstechnica.com/news.ars/post/20081007-motorolas-linux-strategy-evolves-with-android.html

...which is made up of the following six(!) flash files:

http://www.condenet.com/images_external/promo/2008/intel/728x90/intel_728x90_info1.swf
http://www.condenet.com/images_external/promo/2008/intel/728x90/intel_728x90_info2.swf
http://www.condenet.com/images_external/promo/2008/intel/728x90/intel_728x90_info3.swf
http://www.condenet.com/images_external/promo/2008/intel/728x90/intel_728x90_pix1.swf
http://www.condenet.com/images_external/promo/2008/intel/728x90/intel_728x90_pix2.swf
http://www.condenet.com/images_external/promo/2008/intel/728x90/intel_728x90_pix3.swf

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #7)
> This German-English / -Spanish / -French / -Italian / -Chinese translation
> website has ads all over it:
> 
> http://dict.leo.org/

(In reply to comment #9)
> On MacNN, in the right-most column
> http://www.macnn.com/articles/08/10/01/apple.on.mac.pro.toxins/

Lars and philippe, can you guys get me some more specifics on these two (or get the generated source and attach it)?  I'm not seeing anything unblocked on MacNN, and nothing blockable on dict.leo.org, so I'm wondering if I'm seeing something different based on IP?

(In reply to comment #11)
> A couple more Flash ads from yieldmanager.net and edgesuite.net. For example:
> 
> http://l.yieldmanager.net/apex/mediastore/8b1aa6c2-ac81-423d-be88-f9418d4b4db7
>
> http://c6.edgesuite.net/RealMedia/ads/Creatives/SFGate/macys_columbus_day_fixed_APT/macysClmbs_300x250.swf

I added yieldmanager.net, but not the edgesuite.net one.  We can't block edgesuite outright, since it's akamai.  That particular Flash ad should already be blocked by "/RealMedia/ads/" in the URL; however, as is often the case with sfgate.com, I can't see these ads at all (with fresh profiles on both branch and trunk) :-(

Comment 14

[philippe (part-time)]

(In reply to comment #13)
> (In reply to comment #7)
> > This German-English / -Spanish / -French / -Italian / -Chinese translation
> > website has ads all over it:
> > 
> > http://dict.leo.org/
> 
> (In reply to comment #9)
> > On MacNN, in the right-most column
> > http://www.macnn.com/articles/08/10/01/apple.on.mac.pro.toxins/
> 
> Lars and philippe, can you guys get me some more specifics on these two (or get
> the generated source and attach it)?  I'm not seeing anything unblocked on
> MacNN, and nothing blockable on dict.leo.org, so I'm wondering if I'm seeing
> something different based on IP?


On MacNN, the offender seems to have followed the stock market: dive into dev/null. Despite several reloads no ads atm.

On dict.leo org, there is an IBM ad (black horizontal banner) and one for 'Stratley' (a olive green block in the right-hand column) both have the word 'Werbung' under them.

a[href*="advert"] img takes care of those.
There are a few more small banner in the right-hand column, rather 'project sponsers', one from Sun, a hosting provider, and a few more. Nothing distinctive to block on, however.

Comment 15

[philippe (part-time)]

Attachment: generated source for dict-leo-org

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: August-September Omnibus ad-blocking

OK, I'd found those; I just was afraid there were more ads I was missing.  This should cover everything, then, with the exceptions of those at the end of comment 13.

Comment 17

[Stuart Morgan]

Comment on attachment 342500 [details] [diff] [review]
August-September Omnibus ad-blocking

>+div[id^="p360"],
>+div[class^="p360"],

This seems generic enough that it makes me a bit nervous, but I guess we can just keep an eye out for false-positives once it's in the field.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.  Probably won't have baked long enough before we spin 1.6.5 to make it, but that'll remind us to nominate for 1.6.6.

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This is on the short side of our usual window, but Stuart and I talked and he's OK with taking this.  However, I'm going to hold off on landing until bug 448592 (which is likely the last thing we're taking for 1.6.5) gets sr so we can get a few more days to collect any possible regressions.

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the MOZILLA_1_8_BRANCH for 1.6.5.