449512 - Firefox-Qt crashes when typing in searchbox

Status: RESOLVED FIXED

Description

[Jonathan Thomas]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.1; Linux) KHTML/4.1.0 (like Gecko)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/2008080401 Minefield/3.1a2pre

Using the Firefox-Qt build located here: http://browser.garage.maemo.org/news/10/firefoxqt3.tar.gz

I am able to consistently crash Firefox by typing into the searchbox at https://addons.mozilla.org/en-US/firefox/browse/type:2


Reproducible: Always

Steps to Reproduce:
1. Go to https://addons.mozilla.org/en-US/firefox/browse/type:2
2. Type in searchbox
Actual Results:  
Firefox crashed

Expected Results:  
Firefox shouldn't have crashed. Well I mean it's a pre-alpha piece of software so it's expected to crash, but yeah. ;-)

Comment 1

[Oleg Romashin (:romaxa)]

Yep, reproducible
#4  0xb7aff534 in nsFormFillController::SetPopupOpen () from ./libxul.so
#5  0xb7afb6b8 in nsAutoCompleteController::OpenPopup () from ./libxul.so
#6  0xb7afd5cd in nsAutoCompleteController::PostSearchCleanup () from ./libxul.so
#7  0xb7afd83a in nsAutoCompleteController::ProcessResult () from ./libxul.so
#8  0xb7afd941 in nsAutoCompleteController::OnSearchResult () from ./libxul.so

I will check it

Comment 2

[Oleg Romashin (:romaxa)]

Workarround fix for crash is just adding check for mFocusedPopup to nsFormFillController.cpp:225.... but it will not fix major problem with popup windows, which are currently broken.

Here is the debug output for crash workaround:
***************
###!!! ASSERTION: popup frame state doesn't match XULPopupManager open state: '!aPopup->IsOpen() || IsPopupOpen(aPopup->GetContent())', file layout/xul/base/src/nsXULPopupManager.cpp, line 1191
###!!! ASSERTION: popup not in XULPopupManager open list is open: 'IsPopupOpen(aPopup->GetContent()) || state == ePopupClosed || state == ePopupShowing || state == ePopupInvisible', file layout/xul/base/src/nsXULPopupManager.cpp, line 1199
###!!! ASSERTION: How did we get here if it's not safe to run scripts?: 'nsContentUtils::IsSafeToRunScript()', file layout/base/nsPresShell.cpp, line 5570
###!!! ASSERTION: Someone forgot to block scripts: 'aIsSafeToFlush == nsContentUtils::IsSafeToRunScript()', file layout/base/nsPresShell.cpp, line 4515
###!!! ASSERTION: Someone forgot to block scripts: 'aIsSafeToFlush == nsContentUtils::IsSafeToRunScript()', file layout/base/nsPresShell.cpp, line 4515
###!!! ASSERTION: Someone forgot to block scripts: 'aIsSafeToFlush == nsContentUtils::IsSafeToRunScript()', file layout/base/nsPresShell.cpp, line 4515
###!!! ASSERTION: Someone forgot to block scripts: 'aIsSafeToFlush == nsContentUtils::IsSafeToRunScript()', file layout/base/nsPresShell.cpp, line 4515
###!!! ASSERTION: popup frame state doesn't match XULPopupManager open state: '!aPopup->IsOpen() || IsPopupOpen(aPopup->GetContent())', file layout/xul/base/src/nsXULPopupManager.cpp, line 1191
###!!! ASSERTION: popup not in XULPopupManager open list is open: 'IsPopupOpen(aPopup->GetContent()) || state == ePopupClosed || state == ePopupShowing || state == ePopupInvisible', file layout/xul/base/src/nsXULPopupManager.cpp, line 1199
***************

We can see that problem should be fixed in WidgetQt.

Comment 3

[Oleg Romashin (:romaxa)]

Created attachment 332962 [details] [diff] [review]
Crash fix, wip

Something really wrong with QtWidgets focusing and Gecko handling...
Each QtWidget parents/children emits FocusIn/Out events.... and that makes Gecko unhappy.

In Gtk widgets not sending FocusIn/Out events if it happen inside one toplevel widget...

Comment 4

[Oleg Romashin (:romaxa)]

Not reproducible after fixing of bug 449575.