449548 - Shut down skips firefox quit dialog

Status: NEW

(Firefox :: Shell Integration, defect)

Description

[dan_500]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de-DE; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1
Build Identifier: 

Firefox 3.0 on Linux seems always to crash on shut down. There's no quit dialog. I doubt if it's a feature.

Reproducible: Always

Steps to Reproduce:
1. Start Firefox
2. Shut down your computer
Actual Results:  
You'll see no quit dialog and firefox does quit immediately. (On next start firefox will reopen your hundred tabs)

Expected Results:  
Firefox should ask you to save tabs on shutdown, like it always does on quit. (like gedit)

I didn't said "Don't ask this again" at the quit dialog.

Comment 1

[dan_500]

I mean "system shutdown" ("halt")

Comment 2

[Sylvain Pasche]

Confirming on trunk. Session management is implemented in bug 93789, so in theory the confirmation dialog should be displayed on shutdown.

Comment 3

[dan_500]

> in theory the confirmation dialog should be displayed on shutdown.
I like the theory. :)

On last normal session exit of firefox I choose to quit without saving the session and selected to remember my choice, but after the next restart of my X11 session firefox has reopen all my tabs.

It seems that firefox does always saves your firefox session when you close your X11 session. Firefox should show the dialog or use the option you selected before with "Don't ask again".

Comment 4

[dan_500]

Actual:
1. I opened firefox.
2. I opened a lot of tabs.
3. I choose to quit without saving the session and selected to remember my choice.
4. I started firefox.
5. Firefox showed me a new firefox session.
6. I opened a lot of tabs.
7. I restarted my X11 session.
8. I started firefox.
8. Firefox showed me my last firefox session.

I want to see a new session instead of my last session, because I choose to always quit without saving the session. If I didn't choose to remember my choice, the dialog should appear on X11 session exit.

Comment 5

[dan_500]

Another solution would be to ask this question on next start of firefox, like firefox does it after a browser crash. I prefer to ask on quit, like it should be in theory (see Comment #2), like it is in gedit and openoffice.

Comment 7

[Ryan Fugger]

From Bug 488093: If the user has chosen "When Firefox starts: Show my windows and tabs from last time" in preferences/options, the user should not be prompted to restore the session after a "crash", it should just be done automatically.

Comment 9

[dan_500]

Even if I set browser.sessionstore.resume_from_crash to false, it always resumes. browser.startup.page is 1. Firefox version 3.5.8, Ubuntu 9.10.

Even if I set browser.sessionstore.enabled to false. The firefox session will always resume. No dialog. No question. No way to disable it.

Comment 10

[dan_500]

I just enabled /apps/gnome-session/options/auto_save_session and then disabled it. (By the way: this feature does not work with firefox) Than I saved a clear gnome-session. Now firefox does always start with the homepage as I want it. Gnome session management seems to be really crazy.

Comment 11

[dan_500]

* You can enable browser.sessionstore.resume_from_crash at any time and it will work immediately.
* But if you want to disable browser.sessionstore.resume_from_crash, you have to restart your browser manually. Otherwise it won't work.
* Session logout shouldn't be considered as an crash!

(browser.sessionstore.max_resumed_crashes etc works as it should.)

Comment 12

[dan_500]

Additionally: The XSMP support in nsNativeAppSupportUnix.cpp is based on libgnomeui, which is deprecated. So it won't work in GNOME 3. (as same as gnome-vfs etc)

Comment 13

[l1458494]

*Firefox 57.0 still acts with session restore prompt like it crashed on OS shutdown(Linux Mint 18.2), no problem on manual Quit FF.