450072 - Kill obsolete nsResetPref.js

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Mark Banner (:standard8)]

resetPref.js is currently set up only for the old xpfe command line interfaces. SeaMonkey is the only one that packages it for release (although Firefox and xulrunner do actually build it currently).

http://mxr.mozilla.org/comm-central/search?string=nsResetPref.js

I'm proposing that we just kill it. Thoughts?

Comment 1

[Mark Banner (:standard8)]

Note: Moving/Killing will mean that we can tidy up xpfe/components a bit more and hopefully soon start to make that makefile simpler.

Comment 2

[Robert Kaiser]

Is this even used? I think SeaMonkey is using toolkit command line interfaces now, right?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Is this even used? I think SeaMonkey is using toolkit command line interfaces
> now, right?
> 

AFAICT its a command-line only option that provides the ability to reset prefs at the command line (I think it wouldn't run the whole app up).

We are running on the toolkit command line interfaces, nsResetPrefs.js is on the xpfe command line interfaces, hence in its current state it is useless (except maybe as a template ;-) )

Comment 4

[Mark Banner (:standard8)]

Attachment: [checked in] Drop nsResetPrefs.js from mozilla-central

Not seen any objections, let's just drop this code.

Comment 5

[Mark Banner (:standard8)]

Attachment: comm-central changes

Comment 6

[Mark Banner (:standard8)]

Attachment: [checked in] comm-central changes

Correct patch this time

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 334276 [details] [diff] [review]
[checked in] comm-central changes

Checked in, changeset id 134:21dd206080e0

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 334264 [details] [diff] [review]
[checked in] Drop nsResetPrefs.js from mozilla-central

Checked in changeset id 17005:b710fbfb8f23