Closed Bug 450072 Opened 12 years ago Closed 12 years ago

Kill obsolete nsResetPref.js

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files, 1 obsolete file)

resetPref.js is currently set up only for the old xpfe command line interfaces. SeaMonkey is the only one that packages it for release (although Firefox and xulrunner do actually build it currently).

http://mxr.mozilla.org/comm-central/search?string=nsResetPref.js

I'm proposing that we just kill it. Thoughts?
Note: Moving/Killing will mean that we can tidy up xpfe/components a bit more and hopefully soon start to make that makefile simpler.
Is this even used? I think SeaMonkey is using toolkit command line interfaces now, right?
(In reply to comment #2)
> Is this even used? I think SeaMonkey is using toolkit command line interfaces
> now, right?
> 

AFAICT its a command-line only option that provides the ability to reset prefs at the command line (I think it wouldn't run the whole app up).

We are running on the toolkit command line interfaces, nsResetPrefs.js is on the xpfe command line interfaces, hence in its current state it is useless (except maybe as a template ;-) )
Not seen any objections, let's just drop this code.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #334264 - Flags: superreview?(neil)
Attachment #334264 - Flags: review?(neil)
Attached patch comm-central changes (obsolete) — Splinter Review
Attachment #334266 - Flags: review?(neil)
Attachment #334264 - Flags: superreview?(neil)
Attachment #334264 - Flags: superreview+
Attachment #334264 - Flags: review?(neil)
Attachment #334264 - Flags: review+
Correct patch this time
Attachment #334266 - Attachment is obsolete: true
Attachment #334276 - Flags: review?(neil)
Attachment #334266 - Flags: review?(neil)
Attachment #334276 - Flags: review?(neil) → review+
Summary: Kill or move & fix nsResetPref.js → Kill obsolete nsResetPref.js
Comment on attachment 334276 [details] [diff] [review]
[checked in] comm-central changes

Checked in, changeset id 134:21dd206080e0
Attachment #334276 - Attachment description: comm-central changes → [checked in] comm-central changes
Comment on attachment 334264 [details] [diff] [review]
[checked in] Drop nsResetPrefs.js from mozilla-central

Checked in changeset id 17005:b710fbfb8f23
Attachment #334264 - Attachment description: Drop nsResetPrefs.js from mozilla-central → [checked in] Drop nsResetPrefs.js from mozilla-central
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
Target Milestone: mozilla1.9.1a2 → seamonkey2.0alpha
Blocks: 568959
No longer blocks: 568959
You need to log in before you can comment on or make changes to this bug.