Closed Bug 451138 Opened 16 years ago Closed 16 years ago

"Linux nye" reports RLk regression on 2008-08-18

Categories

(SeaMonkey :: General, defect)

x86
Linux
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.0a1

People

(Reporter: sgautherie, Unassigned)

References

Details

(Keywords: memory-leak, regression, Whiteboard: [apply comment 7 workaround before testing])

Regressed between

<http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219079220.1219084773.18326.gz&fulltext=1>
{{
Linux nye Depend bloat on 2008/08/18 10:07:00

######################## END BLOAT STATISTICS

leaks = 0
}}

and

<http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219084800.1219086169.22171.gz>
{{
Linux nye Depend bloat on 2008/08/18 11:40:00  

Error: Leak Test Failed: Number of leaks 1216 is greater than LeakFailureThreshold 1000

######################## END BLOAT STATISTICS

leaks = 1216
}}
Flags: blocking-seamonkey2.0a1?
{{
 => mFreeCount:           32267  --  LEAKED 1 !!!


--NEW-LEAKS-----------------------------------leaks------leaks%-----------------------
nsSystemPrincipal                                36          -
nsBufferedInputStream                            52          -
nsFastLoadFileWriter                            464          -
nsFastLoadFileUpdater                           488          -
nsStringBuffer                                    8          -
nsBinaryOutputStream                             20          -
nsBufferedStream                                 88          -
nsBufferedOutputStream                           60          -
TOTAL                                          1216

--NEW-BLOAT-----------------------------------bloat------bloat%-----------------------
nsConsoleMessage                                 48          -
}}
{{
Updated to revision 1a3f221a40e8402b23d248ba92a9508ae5365669.
pulling from http://hg.mozilla.org/comm-central/
no changes found

Updated to revision 651fd6b9c4601019cf09aec138bba10fdee0f0f2.
pulling from http://hg.mozilla.org/mozilla-central/
Updated to revision 2f7064a3826124277853de44e8f9bef768630469.   <== !

...
}}

Good up to:
651fd6b9c460: Bug 434163. Make sure to not let our hashtable mutate while we're iterating it. r+sr=jst
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 18 Aug 2008 13:06:16 -0400 - rev 16999

Bad before/including:
2f7064a38261: Bug 445951 - missing keyword 'public' in xpcom/glue/nsAutoLock.h, r=bsmedberg
Uli Link <ul.mcamafia@linkitup.de> - Mon, 18 Aug 2008 20:39:19 +0200 - rev 17007

Wild guess, because it touches <nsFastLoadFile.h> and <nsUnicharInputStream.h>:
2f7064a38261: Bug 445951 - missing keyword 'public' in xpcom/glue/nsAutoLock.h, r=bsmedberg
itself
Blocks: 445951
I see more the than 900 leaks with nsFastLoadFile in name.
But the patch didn't alter the semantics of the code at all.

it simply replaced:

class a {};
class a {};

class c : public a, b
{};

with 

class c : public a,
          private b
{};

If (other) code using/iheriting from were relying on public base class "b" a compile time error would happen, not a leak.
The classes have a virtual dtor.

I would suggest tracking leaks on a clean build, or at least clean (objdir)/xpcom from generated headers + object files as sometimes the small changes are not reflected in incremental builds.

The overnext shot could be inheriting public from class "b"
Andrew / Robert,
could you try a clobber and/or selective backouts to narrow down the culprit patch ?
Keywords: mlk
I'll check to see if I see this locally, and if so, it shouldn't be too hard to identify the culprit.
Assignee: nobody → general
Component: Build Config → General
QA Contact: build-config → general
Summary: "Linux nye" reports RLk regression → "Linux nye" reports RLk regression on 2008-08-18
Blocks: 451259
Depends on: 451266
No longer depends on: 451266
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080823104635 SeaMonkey/2.0a1pre] (home, optim default) (W2Ksp4)

I tried <bloatcycle.html> locally and see a RLk too,
but it's much worse (383 leaked objects) than the one on the Linux box,
and it's different (no "FastLoadFile" leak for example) too.

***

Andrew: ping ?
you need to hack a workaround for bug 391318.  I have "rdf:extensions" changed to "rdf:local-store" in suite/browser/navigatorOverlay.xul.
(In reply to comment #7)
> you need to hack a workaround for bug 391318.  I have "rdf:extensions" changed
> to "rdf:local-store" in suite/browser/navigatorOverlay.xul.

Ah, thanks !

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080823140037 SeaMonkey/2.0a1pre] (home, optim default) (W2Ksp4)

With that workaround, the whole leak I was seeing goes away :-|
Which confirms that I'm not seeing this bug (locally).
(In reply to comment #8)
> Which confirms that I'm not seeing this bug (locally).

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080823180458 SeaMonkey/2.0a1pre] (home, debug default) (W2Ksp4)

Neither with a debug build.
Whiteboard: [apply comment 7 workaround before testing]
The leak is bug 389734 (courtesy of nsResetPref removal in bug 450072 on 8/18).

I've removed the busted symlink on nye
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
(In reply to comment #10)
> *** This bug has been marked as a duplicate of bug 389734 ***

I wouldn't say duplicate: the other bug is about the code, this one ends up being about the box.

Thanks for fixing it, anyway !

***

Uli, this was indeed about the "fastload" after all, but not related to your patch ;->
Blocks: 389734
No longer blocks: 445951, 451259
Depends on: 450072
Flags: blocking-seamonkey2.0a1? → in-testsuite-
Resolution: DUPLICATE → FIXED
Target Milestone: --- → seamonkey2.0alpha
V.Fixed, between

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219553520.1219553809.366.gz
Linux nye Depend bloat on 2008/08/23 21:52:00
"Error: Leak Test Failed: Number of leaks 1216 is greater than LeakFailureThreshold 1000"

and

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1219557120.1219558042.10292.gz
Linux nye Depend bloat on 2008/08/23 22:52:00
(Usual bug 448137.)
Status: RESOLVED → VERIFIED
Blocks: 451962
No longer blocks: 451962
You need to log in before you can comment on or make changes to this bug.