450239 - helper application not found error shows null instead of path

Status: VERIFIED DUPLICATE of bug 442196

(Toolkit :: Downloads API, defect)

Description

[timeless]

Attachment: patch by Julien Danjou <[e-mail]>

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494694

steps to reproduce:
When clicking on a downloadable link and choosing an application to open
the file with, if the application does not exists,

actual results:
the message printed when clicking OK contains (null)

expected results:
instead of the path.

Comment 1

[Shawn Wilsher :sdwilsh]

what's the likelihood of getting a test for this?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 333391 [details] [diff] [review]
patch by Julien Danjou <[e-mail]>

r=biesi but I'm not really a toolkit peer

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> what's the likelihood of getting a test for this?
Mike?

Comment 4

[Mike Hommey [:glandium]]

No idea ; how do you test the content of a dialog ?

Comment 5

[Shawn Wilsher :sdwilsh]

We've got lots of chrome tests already for the download manager UI here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/tests/chrome/

And this one tests the helper apps dialog:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/tests/chrome/test_unkownContentType_dialog_layout.xul

I'd by happy to assist in answering any questions to get the test done.

Comment 6

[Mike Hommey [:glandium]]

The bug was fixed by
http://hg.mozilla.org/mozilla-central/rev/653def1eb60e
(which doesn't reference this bug, and which bug it references doesn't match the issue, by the way ; Ccing roc, who did the push)

Is a testcase for this still wanted?

Comment 7

[Mike Hommey [:glandium]]

Found the other bug.