450519 - No breakpad reports since comm-central move

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P1)

Description

[Joe Sabash [:JoeS1]]

STR:
 Force a crash (pick your poison, my favorite is playing a wav file with the VLC plugin)
 Breakpad dialog does not appear, goes directly to Microsoft crash dialog.

The last crashes that I have logged were:
004ec9a3-50eb-11dd-acc2-0013211cbf8a	7/13/2008	10:50 AM
21a65b9e-4a8d-11dd-8750-001a4bd43e5c	7/5/2008	8:23 AM

Which I believe were due to the same issue.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080813031200 Shredder/3.0b1pre ID:20080813031200

Comment 1

[Joe Sabash [:JoeS1]]

BTW besides crash-stats.mozilla.com being very lethargic tonight, there does not seem to a category for Thunderbird 3.0b1pre included in the index at:
http://crash-stats.mozilla.com/topcrasher/index/004ec9a3-50eb-11dd-acc2-0013211cbf8a

Not sure how to file a bug on that.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Not sure how to file a bug on that.

It is already filed, see bug 450344

Comment 3

[Wayne Mery (:wsmwk)]

So, this may be due to "Enabled=1" missing from application.ini "[Crash Reporter]" section.  Cause according to Ted - "It appears that trunk Thunderbird Win32 builds are not building with MOZILLA_OFFICIAL=1"

I have an 20080808 build application.ini which is *OK*. And a 20080813 where Enabled=1 is missing.

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix

I see the problem. The old tinderboxes used to set MOZILLA_OFFICIAL in their build script. When we moved to buildbot we didn't know about this so we missed it.

Somehow we did manage to add it to mac, but not windows or linux.

Comment 5

[Mark Banner (:standard8)]

I checked in the patch yesterday, and Wayne has checked the windows builds which now have Enabled=1 in application.ini for crash reporter (and he got the crash reporter up).

I've also checked the linux builds and these now have Enabled=1 as well. Mac has been working fine for some time.


Patch was changeset id 247:d08f67abe975 on http://hg.mozilla.org/build/index.cgi/buildbot-configs/