450695 - Pushlog date query should accept ISO dates without minutes/seconds

Status: VERIFIED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Jesse Ruderman]

Bug 437445 added query-by-date to the hg pushlog, but the date parsing is a bit weird.  Since I'm used to Bonsai, at first I thought it didn't accept ISO 8601 dates at all.

"2008-07-01 03:00:00" is interpreted correctly, but
"2008-07-01 03:00" somehow becomes "today 03:00"

Ted says anything that isn't a full ISO date gets passed to the natural-language "parsedatetime" module.  I think the initial check should be changed to accept truncated ISO dates (missing the seconds, or missing the minutes and seconds).  These are valid ISO dates, IIUC.

Comment 1

[PikeUK]

It also fails if you include a T as the separator between date and time (as specified in ISO 8601) instead of a space and if you include any whitespace at the beginning or end of the date (as often happens when copy and pasting).

I can file separate bugs for these if you'd prefer.

Comment 2

[(not currently active) Ted Mielczarek]

I'll fix those as part of this. (Although maybe not the 'T' in the date, who's seriously going to use that?)

Comment 3

[PikeUK]

(In reply to comment #2)
> I'll fix those as part of this. (Although maybe not the 'T' in the date, who's
> seriously going to use that?)

I did the first time I tried it for some reason, but yeah guess it's not a common thing. I'd copied in a 14 digit new-style buildid and was manually adding the separators, so I suppose another request is for it to be able to parse the new build id format but perhaps that's off-topic for this bug.

Comment 4

[Serge Gautherie (:sgautherie)]

Even without the hour, if that's valid...

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: fix

This will let you enter dates like "2008-11-21" "2008-11-21 11" "2008-11-21 11:30" "2008-11-21 11:30:01".

I need to write some tests for it, but it works in my initial testing.

Comment 6

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/users/bsmedberg_mozilla.com/hgpoller/rev/e955a1f05004

Going to file a bug right away to get all my recent pushlog changes deployed.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> I suppose another request is for it to be able to
> parse the new build id format but perhaps that's off-topic for this bug.

Please, file a separate bug, if you want this.

***

V.Fixed, per comment 5 steps.

NB: 'T' is not (yet) supported, per comment 2.

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/7172e858e72c