Pushlog date query should accept ISO dates without minutes/seconds

VERIFIED FIXED

Status

defect
VERIFIED FIXED
11 years ago
5 years ago

People

(Reporter: jruderman, Assigned: ted)

Tracking

Details

(Whiteboard: [See |hg help dates|], URL)

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Bug 437445 added query-by-date to the hg pushlog, but the date parsing is a bit weird.  Since I'm used to Bonsai, at first I thought it didn't accept ISO 8601 dates at all.

"2008-07-01 03:00:00" is interpreted correctly, but
"2008-07-01 03:00" somehow becomes "today 03:00"

Ted says anything that isn't a full ISO date gets passed to the natural-language "parsedatetime" module.  I think the initial check should be changed to accept truncated ISO dates (missing the seconds, or missing the minutes and seconds).  These are valid ISO dates, IIUC.

Comment 1

11 years ago
It also fails if you include a T as the separator between date and time (as specified in ISO 8601) instead of a space and if you include any whitespace at the beginning or end of the date (as often happens when copy and pasting).

I can file separate bugs for these if you'd prefer.
I'll fix those as part of this. (Although maybe not the 'T' in the date, who's seriously going to use that?)

Comment 3

11 years ago
(In reply to comment #2)
> I'll fix those as part of this. (Although maybe not the 'T' in the date, who's
> seriously going to use that?)

I did the first time I tried it for some reason, but yeah guess it's not a common thing. I'd copied in a 14 digit new-style buildid and was manually adding the separators, so I suppose another request is for it to be able to parse the new build id format but perhaps that's off-topic for this bug.
Even without the hour, if that's valid...
Whiteboard: [See |hg help dates|]
Posted patch fixSplinter Review
This will let you enter dates like "2008-11-21" "2008-11-21 11" "2008-11-21 11:30" "2008-11-21 11:30:01".

I need to write some tests for it, but it works in my initial testing.
Pushed:
http://hg.mozilla.org/users/bsmedberg_mozilla.com/hgpoller/rev/e955a1f05004

Going to file a bug right away to get all my recent pushlog changes deployed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(In reply to comment #3)
> I suppose another request is for it to be able to
> parse the new build id format but perhaps that's off-topic for this bug.

Please, file a separate bug, if you want this.

***

V.Fixed, per comment 5 steps.

NB: 'T' is not (yet) supported, per comment 2.
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.