Closed Bug 450725 Opened 16 years ago Closed 16 years ago

Argentinean Sunbird -> many TZ error at startup

Categories

(Mozilla Localizations :: es-AR / Spanish (Argentina), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: andreas.treumann, Assigned: Fallen)

References

Details

Attachments

(1 file, 1 obsolete file)

STEPS TO REPRODUCE:
===================

- create a new profile and start the argentinean version of sunbird
- check the error console

RESULT:
=======

- output in error console:

Error: Evitando huso horario local 'América/Argentina/Buenos_Aires'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/New_York'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Chicago'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Denver'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Phoenix'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Los_Ángeles'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Anchorage'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Adak'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'Pacífico/Honolulu'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Puerto_Rico'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Halifax'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Ciudad_de_México'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'América/Sao_Paulo'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'Europa/Londres'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'Europa/París'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'Asia/Singapur'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'Asia/Tokio'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'África/Lagos'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'África/Johannesburgo'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'África/Nairobi'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'Pacífico/Auckland'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/Ar/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

EXPECTED RESULT:
================

- no errors
REPRODUCIBLE:
=============

- always
Timezone names in property "likelyTimezone" must not be translated and must be specified in English:

http://bonsai-l10n.mozilla.org/cvsblame.cgi?file=l10n/es-AR/calendar/chrome/calendar/calendar.properties&rev=1.10&mark=181,206#179
Please mind also bug 449646.
(In reply to comment #2)
> Please mind also bug 449646.

The error message for this issue is:

Error: Failed to read 'monthlyOrder' from chrome://calendar/locale/sun-calendar-event-dialog.properties. Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: calGetString :: line 670"  data: no]
Archivo Fuente: chrome://calendar/content/calUtils.js
Línea: 676

The cause is some unknown or invalid character in property "removeCalendarsText": http://bonsai-l10n.mozilla.org/cvsblame.cgi?file=l10n/es-AR/calendar/chrome/prototypes/sun-calendar-event-dialog.properties&rev=1.2.2.5&mark=135#132

Therefore parsing the .properties file fails before it can read the requested entities resulting in a similar result as reported in Bug 449646.
Marcelo, any update on the situation here from you?
Just working on that.
I was busy with Chris Hoffman on his visit to Argentina.
Status: NEW → ASSIGNED
Fixed on MOZILLA_1_8_BRANCH.
Do I need to fix SUNBIRD_0_8_BRANCH?
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
No, the Sunbird 0_8_BRANCH is dead. You can safely ignore it.
I checked this issue in sunbird 20080902 and now I get 'only' four errors at startup.

Error: Evitando huso horario local 'America/Argentina/Buenos Aires'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'America/Argentina/La Rioja'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'America/Argentina/Rio Gallegos'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768

Error: Evitando huso horario local 'America/Argentina/San Juan'. TypeError: tz has no properties
Archivo Fuente: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/sunbird-0.9pre.es-AR.win32/sunbird/js/calTimezoneService.js
Línea: 768
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #8)
L10n tinderboxen are still busted due to the check-in from Bug 437441. Therefore no current repackaged builds are available. <http://tinderbox.mozilla.org/Mozilla1.8-l10n-es-AR/>
I checked this again with sunbird 20080903, bug still exist.
From looking at the error messages above it seems the the "_" character in the Olson timezone name was replaced by " ". For example in the es-AR file it's "America/Argentina/La Rioja" but should be "America/Argentina/La_Rioja".
This bug occurs also in lightning.
Attached patch patch (obsolete) — Splinter Review
As Stefan commented in comment #11, likelyTimezone must be unlocalized timezone ids:
<http://mxr.mozilla.org/l10n-mozilla1.8/source/es-AR/calendar/chrome/calendar/calendar.properties#206>

This patch should fix that.

Also I see that some timezones are still unlocalized, and still carry an underline '_', e.g.
<http://mxr.mozilla.org/l10n-mozilla1.8/source/es-AR/calendar/chrome/calendar/timezones.properties#324>
Please keep care of SUNBIRD_0_9_BRANCH as it's the current release branch.
We're right before 0.9 RC1; it would be nice to have more traction on this. Thanks!
Attached patch patch - v2Splinter Review
Looking at the timezones.properties it seems the strings are translated, but the _ has not been replaced by a space and St xyz has not been replaced with St. xyz.

This patch takes care and includes Daniel's patch. I hope everything is right with utf8, cvs diff for some reason outputted the patch in latin1 even though the original file was utf8.
Assignee: mpoli → philipp
Attachment #337437 - Attachment is obsolete: true
Attachment #337629 - Flags: review?(bugzilla)
Comment on attachment 337629 [details] [diff] [review]
patch - v2

For the sake of providing an rc1, I'd rather check this in now.

If something is wrong with what I've done, please provide a new patch or at least tell me about it.
Attachment #337629 - Flags: review?(bugzilla)
Checked-in as requested on IRC by Fallen on MOZILLA_1_8_BRANCH, SUNBIRD_0_9_BRANCH and on CVS TRUNK.
Resolving as fixed. It should be verified
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: