450807 - [Windows] xpcshell-tests: test_bug_401430.js fails intermittently

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Shawn Wilsher :sdwilsh]

The test is failing - could be not a long enough timeout, but it is a hardware box, so I'm suspect of that.

Comment 1

[Marco Bonardo [:mak]]

today's failure on 1.9.1 branch:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.1/1231411433.1231416615.20356.gz

is Bug 464326 the same?

Comment 3

[Serge Gautherie (:sgautherie)]

{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/1244838990.1244845362.4040.gz
WINNT 5.2 comm-1.9.1 unit test on 2009/06/12 13:36:30

TEST-UNEXPECTED-FAIL | e:\builds\slave\comm-1.9.1-win32-unittest\build\objdir\mozilla\_tests\xpcshell\test_dm\unit\test_bug_401430.js | false == true - See following stack:
[...]
JS frame :: e:\builds\slave\comm-1.9.1-win32-unittest\build\objdir\mozilla\_tests\xpcshell\test_dm\unit\test_bug_401430.js :: checkResult :: line 46
}

Code is:
{
45 function checkResult() {
46   do_check_true(checkRecentDocsFor(resultFileName));
}

Comment 4

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey2.0/1249405006.1249415404.9480.gz
WINNT 5.2 comm-1.9.1 unit test on 2009/08/04 09:56:46
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey2.0/1249411693.1249420049.27935.gz
WINNT 5.2 comm-1.9.1 unit test on 2009/08/04 11:48:13

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird3.0/1250005445.1250009862.10101.gz
Win2k3 comm-1.9.1 check on 2009/08/11 08:44:05

Comment 6

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird3.0/1250858939.1250865428.10142.gz
Win2k3 comm-1.9.1 check on 2009/08/21 05:48:59

Comment 7

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1251129177.1251132479.12584.gz
Win2k3 comm-central check on 2009/08/24 08:52:57
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1251134152.1251138704.21994.gz
Win2k3 comm-central check on 2009/08/24 10:15:52

Comment 8

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird3.0/1251797227.1251801034.445.gz
Win2k3 comm-1.9.1 check on 2009/09/01 02:27:07

Comment 9

[Shawn Wilsher :sdwilsh]

WINNT 5.2 mozilla-central test everythingelse [testfailed] Started 15:32, finished 16:09
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1252621947.1252624104.20979.gz&fulltext=1

Comment 10

[Johnathan Nightingale [:johnath]]

This test has been touched by Ted, Gavin and Ehsan, and is still failing. Any of you three have thoughts?

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6-Unittest/1254222761.1254225210.9086.gz
WINNT 5.2 mozilla-1.9.2 test everythingelse on 2009/09/29 04:12:41

Comment 11

[(not currently active) Ted Mielczarek]

My changes were mostly just a tree-wide refactoring, and then a followup fix to the test as fallout from that. The test checks that downloaded files get put into the "Recent Documents" list. My refactoring change accidentally caused the file to get downloaded to $TEMP, which apparently means the file doesn't go into "Recent Documents", so I changed the test to download to the test directory instead.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/test/unit/test_bug_401430.js#107

The test uses an arbitrarily-chosen 1000ms timeout, because apparently the change to the registry in response to the SHAddToRecentDocs call doesn't happen synchronously (our registry APIs can't get the new value immediately, anyways).

I'm not sure that there's much we can do to address this besides removing the test or just increasing the timeout.

Comment 13

[Marco Bonardo [:mak]]

we can use a polling strategy, check after 1000ms, if it's not present check again after 500ms or so, till we reach a max timing of 5s.

Comment 14

[Marco Bonardo [:mak]]

taking to try polling.

Comment 15

[Marco Bonardo [:mak]]

Attachment: patch v1.0 [Checked in: Comment 18 & 20 & 21]

Comment 16

[Ed Lee :Mardak]

Comment on attachment 405495 [details] [diff] [review]
patch v1.0
[Checked in: Comment 18 & 20 & 21]

>--- a/toolkit/components/downloads/test/unit/test_bug_401430.js
> function checkResult() {
>   // delete the saved file (this doesn't affect the "recent documents" list)
>   var resultFile = do_get_file(resultFileName);
>   resultFile.remove(false);
> 
>+  // Need to poll RecentDocs value because the SHAddToRecentDocs call
>+  // doesn't update the registry immediately.
>+  do_timeout(POLL_REGISTRY_TIMEOUT, "pollRecentDocs();");
I suppose you could just call pollRecentDocs() instead of on a timeout, but you can leave as is.

r=Mardak

Comment 17

[Marco Bonardo [:mak]]

yes but i prefer giving some breath to the main thread in tests, and i really doubt the value will be in the registry immediately. so i did that

Comment 18

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/23d4e625a481

Comment 19

[Serge Gautherie (:sgautherie)]

Bug still on m-1.9.1:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey2.0/1283272317.1283282005.17096.gz
WINNT 5.2 comm-1.9.1 unit test on 2010/08/31 09:31:57

Comment 20

[Serge Gautherie (:sgautherie)]

Comment on attachment 405495 [details] [diff] [review]
patch v1.0
[Checked in: Comment 18 & 20 & 21]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9e91f8ff24c8

Comment 21

[Serge Gautherie (:sgautherie)]

Comment on attachment 405495 [details] [diff] [review]
patch v1.0
[Checked in: Comment 18 & 20 & 21]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/75b0292a274a