Last Comment Bug 450991 - Number in "Order Received" column becomes negative, when mail's offset in local mail folder file exceeds 2GB
: Number in "Order Received" column becomes negative, when mail's offset in loc...
Status: RESOLVED FIXED
: fixed1.8.1.18
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 3.0b1
Assigned To: Hiroyuki Ikezoe (:hiro)
:
Mentors:
: 443230 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-17 21:03 PDT by WADA
Modified: 2010-12-13 09:02 PST (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Screen shot of negative number in "Order Received" column (40.12 KB, image/png)
2008-08-17 21:03 PDT, WADA
no flags Details
Workaround patch for 1.8 branch (806 bytes, patch)
2008-08-18 16:51 PDT, Hiroyuki Ikezoe (:hiro)
mozilla: review+
neil: superreview+
dveditz: approval1.8.1.18+
Details | Diff | Splinter Review
Same patch for trunk [Checkin: Comment 5] (574 bytes, patch)
2008-08-18 16:58 PDT, Hiroyuki Ikezoe (:hiro)
mozilla: review+
neil: superreview+
Details | Diff | Splinter Review

Description WADA 2008-08-17 21:03:06 PDT
Created attachment 334216 [details]
Screen shot of negative number in "Order Received" column

> [App] Name=Thunderbird, Version=3.0b1pre, BuildID=20080814031842
>       ID={3550f703-e582-4d05-9a08-453d09bdfdc6}
> [Gecko] MinVersion=1.9.1a2pre, MaxVersion=1.9.1a2pre
> On MS Win-XP SP3

Number in "Order Received" column becomes negative, when mail's offset in local mail folder file exceeds 2GB.
Sort order is proper(sorted by value of 32bit unsigned integer). So it looks to be display only issue(treated as 32bit signed integer). Possibly due to common module for Win,Linux,Mac OS. (Mail folder file greater then 2GB is supported by NSPR for Win only)

Note:
This bug's problem is minor. But critical issues such as Bug 450359 really exist, due to insuffient changes after support of mail folder file greater than 2GB.
Comment 1 Hiroyuki Ikezoe (:hiro) 2008-08-18 16:51:15 PDT
Created attachment 334367 [details] [diff] [review]
Workaround patch for 1.8 branch

support 4GB over mailbox.
Comment 2 Hiroyuki Ikezoe (:hiro) 2008-08-18 16:58:33 PDT
Created attachment 334372 [details] [diff] [review]
Same patch for trunk
[Checkin: Comment 5]
Comment 3 David :Bienvenu 2008-08-18 17:05:35 PDT
Comment on attachment 334372 [details] [diff] [review]
Same patch for trunk
[Checkin: Comment 5]

thx for the patch
Comment 4 David :Bienvenu 2008-08-20 08:02:40 PDT
Comment on attachment 334367 [details] [diff] [review]
Workaround patch for 1.8 branch

thx for the patch
Comment 5 Serge Gautherie (:sgautherie) 2008-10-14 15:32:28 PDT
Comment on attachment 334372 [details] [diff] [review]
Same patch for trunk
[Checkin: Comment 5]

http://hg.mozilla.org/comm-central/rev/bab601fb4812
Comment 6 Serge Gautherie (:sgautherie) 2008-10-14 15:34:46 PDT
I think you need to get some kind of additional approval before branch checkin.
Comment 7 Frederic Bezies 2008-10-15 02:25:29 PDT
I don't know if it is related, but I cannot unfold any thread in mailnews or click on the top list message without getting a crash.
Comment 8 Mark Banner (:standard8) 2008-10-15 07:02:13 PDT
Please add checkin-needed back once this has got approval.

Someone also needs to confirm whether or not comment 7 is a regression from this.
Comment 9 Magnus Melin 2008-10-15 10:25:14 PDT
Frederic: probably best to file a followup bug. But anyway, can you give the breakpad crash id? Is the folder in question over 2GB?
Comment 10 Dan Mosedale (:dmose) 2008-10-15 13:00:07 PDT
Comment on attachment 334367 [details] [diff] [review]
Workaround patch for 1.8 branch

a=dmose; however, bugzilla doesn't seem to think I have authority to set approval1.8.1.18+ for some reason.
Comment 11 Frederic Bezies 2008-10-15 21:11:49 PDT
Magnus : I target wrong bug as guilty for my crashes. It was bug 460058 here. Sorry for my mistake :/
Comment 12 Daniel Veditz [:dveditz] 2008-10-20 17:56:47 PDT
fix checked into the 1.8 branch
Comment 13 Wayne Mery (:wsmwk, NI for questions) 2010-12-13 09:02:24 PST
*** Bug 443230 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.