451292 - No session restore confirmation startup dialog when a page suddenly starts crashing Firefox

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Martijn Wargers (dead)]

I have the option "show my windows and tabs from last time" set.

I often test older builds to look for regression ranges.
I noticed that when I load a file that crashes in newer builds but not in older builds, and then I close the older build without closing the file before that, the newer build crashes instantly.
I guess the first time could be expected since I didn't come from a crashed state. But the when I restart this newer build, I would expect the session restore confirmation startup dialog to popup, preventing this crash to happen again. But instead the crashing page is loaded again, leaving me in a vicious circle.

Comment 1

[Simon Bünzli]

We currently don't write to sessionstore.js until (some arbitrary) 10 seconds after startup - and it depends on that file whether we consider the last session crashed. So we really should set it to "running" before we start restoring anything.

Comment 3

[Simon Bünzli]

This bug should soon be fixed (in bug 395488).

Comment 4

[Simon Bünzli]

FIXED in bug 395488.

Comment 5

[Martijn Wargers (dead)]

Well, I don't get a session restore confirmation dialog at all anymore, no matter if I'm crashing directly or after half an hour.

Comment 6

[Simon Bünzli]

WFM. Does a clean profile work? Then again, this could just as well be the same issue that's causing bug 463015. If a clean profile doesn't help, please wait until bug 463015 is fixed before trying again.

Comment 7

[Martijn Wargers (dead)]

Yeah, I'm suffering from bug 463015.

Comment 9

[Martijn Wargers (dead)]

Well, I'm afraid I'm still seeing this bug, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081118 Minefield/3.1b2pre

And it seems indeed still related to the 10s thing. It seems as when I crash within 10s, I don't get the session restore 'dialog'.

Comment 10

[Simon Bünzli]

(In reply to comment #9)
Are you repeatedly crashing? We no longer display anything after the first crash, only after subsequent crashes.

Comment 11

[Martijn Wargers (dead)]

Ah, I see. Yeah, that works as you describe.
However, I know notice that if you crash before 10 seconds, the url is not saved. Probably not a big deal, though.

Comment 12

[Simon Bünzli]

(In reply to comment #11)
> I know notice that if you crash before 10 seconds, the url is not saved.

That's a special case of the general rule: you'll lose anything typed in since the last save operation - and by default we save at most every 10 seconds.

Comment 13

[Martijn Wargers (dead)]

Thanks for the explanation, Simon.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Had a lot of crashes lately and this is working fine. Marking as verified with builds like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090309 Shiretoko/3.1b4pre ID:20090309020654