463015 - 'Recently Closed Tabs' list not updating

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Recent History->Closed tabs list will not update after closing/restarting the browser.

1. Close Firefox/Minefield
2. Quit at the prompt - note you will not be saving your session
3. Restart Minefield
4. Open a couple tabs or more, close one - note name of tab is shown in History->Recently closed
5. Close browser - Save session this time
6. Restart Minefield again
7. Open a tab and close it - use a different site so as not to confuse yourself
8. History->Recently closed tabs - note that the tab you just opened/closed is not in the list.

No errors in the console. No idea how long this has been happening. I need to test with a new profile, but I'm pretty sure that will make no difference as I think I saw the same last night when I posted that it occurred again.

Comment 1

[Luke Iliffe (Harlequin99)]

Works in the nightly:
Mozilla5.0 (Windows; U; Windows NT 5.1; en-US; rv1.9.1b2pre) Gecko20081102 Minefield3.1b2pre.zip

Broken in nightly:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081103 Minefield/3.1b2pre

Does anyone know where the hourly archives are now kept?

Comment 2

[Simon Bünzli]

This is a regression of bug 395488 which exposed bug 366509 in a more prominent manner. I hope to fix this whole class of issues for good over in bug 407110.

Comment 4

[Jay Rossiter]

I may have skipped a build or two.  I first began seeing this today in 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081105 Minefield/3.1b2pre

I thought it was related to the new excess-tab-viewing interface.

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

The checkin for bug 407110 seems to have fixed this, but since 407110 is not marked 'Fixed', I'm going to leave this open for now.

Tested using hourly build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre Firefox/3.0 ID:20081106031059

Comment 6

[Simon Bünzli]

FIXED in bug 407110.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre and on OS X.

Simon, something we could have for the testsuite?

Comment 8

[Simon Bünzli]

Theoretically, we already test that closed tabs can be reopened (see the bottom part of http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/test/browser/browser_350525.js ).

This specific bug was however caused by a core bug that hasn't really been identified, so there isn't much I could further test against. If you want, you could include the StR from comment #0 in a test about restoring a session after a restart, though (i.e. just extend the test to make sure that not only can closed tabs be reopened after a restart but new tabs can be closed and reopened as well).

Comment 10

[Adam Olejniczak]

Hi,

In FF 3.0.4 on Linux I still have problem with Recently Closed Tabs not updating. 
The problem was reported as Ubuntu bug here:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/129749

Appeared that root cause was:
browser.sessionstore.enabled = false

setting it back to true makes Recently Closed Tabs update again.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

(setting this as blocking as its dupe was blocking)

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #6)
> FIXED in bug 407110.

Since that's verified1.9.1, marking this fixed1.9.1 as well.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #10)
> In FF 3.0.4 on Linux I still have problem with Recently Closed Tabs not
> updating. 

Yes, it isn't fixed on the 1.9.0 branch which is Firefox 3.0.x.

Comment 14

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7782 added to Litmus.