Closed
Bug 451392
Opened 16 years ago
Closed 15 years ago
Move testing/release scripts to hg and update Bootstrap to pull them from there
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: coop, Assigned: coop)
References
Details
Attachments
(2 files, 1 obsolete file)
7.42 KB,
patch
|
bhearsum
:
review-
coop
:
checked-in+
|
Details | Diff | Splinter Review |
25.83 KB,
patch
|
nthomas
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
There are a bunch of l10n and update verification scripts that currently live in CVS. We need to move the scripts from testing/release/common, testing/release/l10n, and testing/release/updates to hg.mozilla.org/build/tools, and then update the Bootstrap code to pull them from there.
Assignee | ||
Updated•16 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•16 years ago
|
||
I copied the release scripts over into hg.m.o/build/tools this morning. changeset: 6:ca4c49d7d347 Working on the Bootstrap patch now.
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → NEW
Priority: P2 → P3
Assignee | ||
Comment 2•15 years ago
|
||
I've re-imported the release scripts with CVS history. changeset: 91:1e3adb91ad78
Status: NEW → ASSIGNED
Priority: P3 → P2
Assignee | ||
Comment 3•15 years ago
|
||
* added an hgUpdate() method which can be called automatically from hgClone() if a tag is specified * added hgToolsTag to the configs * added https:// to the front of the hgToolsRepo for Thunderbird to match the Firefox configs
Attachment #361947 -
Flags: review?(bhearsum)
Comment 4•15 years ago
|
||
Comment on attachment 361947 [details] [diff] [review] Use hg version of l10nverify script >? Bootstrap.kpf >Index: Bootstrap/Step.pm >=================================================================== >RCS file: /cvsroot/mozilla/tools/release/Bootstrap/Step.pm,v >retrieving revision 1.21 >diff -u -p -r1.21 Step.pm >--- Bootstrap/Step.pm 29 Jan 2009 22:57:21 -0000 1.21 >+++ Bootstrap/Step.pm 12 Feb 2009 06:32:08 -0000 >@@ -307,6 +307,41 @@ sub HgClone { > cmdArgs => ['clone', $repo], > dir => $workDir > ); >+ >+ if (exists($args{'tag'}) and For consistency, please process this argument to $tag at the top of function with the other args. >+ if (!exists($args{'tag'}) or >+ $args{'tag'} =~ /^default$/i or >+ $args{'tag'} =~ /^tip$/i) { tip != default, actually. If the latest commit is on a different branch it will be tip. I don't imagine we'll have branches in this repository, but I think you should pull this check out, anyways. This looks fine otherwise. r=bhearsum with those nits addressed.
Attachment #361947 -
Flags: review?(bhearsum) → review-
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 361947 [details] [diff] [review] Use hg version of l10nverify script Nits fixed.
Attachment #361947 -
Flags: checked‑in+
Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 6•15 years ago
|
||
I committed a follow up to this, adding "hgToolsTag = default" to fx-moz18-bootstrap.cfg fx-moz18-staging-bootstrap.cfg tb-moz18-bootstrap.cfg tb-moz18-staging-bootstrap.cfg
Comment 7•15 years ago
|
||
(In reply to comment #2) > I've re-imported the release scripts with CVS history. > > changeset: 91:1e3adb91ad78 Something must have gone wrong with this. Examples, the big jump from 3.0rc3 and 3.0.6 http://hg.mozilla.org/build/tools/file/tip/release/updates/moz19-firefox-win32.cfg and missing 2.0.0.16/17/18 in http://hg.mozilla.org/build/tools/file/tip/release/updates/moz18-thunderbird-win32.cfg Could you take another look Chris, or point me to the script that's used to import history from CVS ? I'll need it for Tb2.0.0.21 and we should probably retest 3.0.7 before it's released.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•15 years ago
|
||
These versions got lost in the CVS->hg import.
Attachment #365289 -
Flags: review?(nthomas)
Comment 9•15 years ago
|
||
Comment on attachment 365289 [details] [diff] [review] Replace missing product versions from update configs (hg) >diff --git a/release/updates/moz18-firefox-linux.cfg b/release/updates/moz18-firefox-linux.cfg > # 2.0.0.16 linux > release="2.0.0.16" product="Firefox" platform="Linux_x86-gcc3" build_id="2008070204" locales="af ar be bg ca cs da de el en-GB en-US es-AR es-ES eu fi fr fy-NL ga-IE gu-IN he hu it ja ka ko ku lt mk mn nb-NO nl nn-NO pa-IN pl pt-BR pt-PT ro ru sk sl sv-SE tr uk zh-CN zh-TW" channel="betatest" from="/firefox/releases/2.0.0.16/linux-i686/%locale%/firefox-2.0.0.16.tar.gz" aus_server="https://aus2.mozilla.org" ftp_server="stage-old.mozilla.org/pub/mozilla.org" to="/firefox/nightly/2.0.0.17-candidates/build2/firefox-2.0.0.17.%locale%.linux-i686.tar.gz" Please trim out everything after the from="... for release="2.0.0.16" Changes to moz18-firefox-mac.cfg and moz18-firefox-win32.cfg are missing (need to add 2.0.0.17/18/19, and remove from=".. for 2.0.0.16) >diff --git a/release/updates/moz18-thunderbird-mac.cfg b/release/updates/moz18-thunderbird-mac.cfg Please trim out everything after the from="... for release="2.0.0.14" >diff --git a/release/updates/moz18-thunderbird-win32.cfg b/release/updates/moz18-thunderbird-win32.cfg Please trim out everything after the from="... for release="2.0.0.14" >diff --git a/release/updates/moz19-firefox-win32.cfg b/release/updates/moz19-firefox-win32.cfg Please trim out everything after the from="... for release="3.0.5" Also need to bring over moz19-firefox-{win32,linux,mac}-major.cfg
Attachment #365289 -
Flags: review?(nthomas) → review-
Assignee | ||
Comment 10•15 years ago
|
||
Addresses Nick's comments.
Attachment #365289 -
Attachment is obsolete: true
Attachment #365338 -
Flags: review?(nthomas)
Comment 11•15 years ago
|
||
Comment on attachment 365338 [details] [diff] [review] Replace missing product versions from update configs (hg), v2 Looks great, thanks coop.
Attachment #365338 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 12•15 years ago
|
||
Comment on attachment 365338 [details] [diff] [review] Replace missing product versions from update configs (hg), v2 changeset: 234:646c76b7067e
Attachment #365338 -
Flags: checked‑in+
Assignee | ||
Updated•15 years ago
|
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•