451392 - Move testing/release scripts to hg and update Bootstrap to pull them from there

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris Cooper [:coop] (he/him)]

There are a bunch of l10n and update verification scripts that currently live in CVS. We need to move the scripts from testing/release/common, testing/release/l10n, and testing/release/updates to hg.mozilla.org/build/tools, and then update the Bootstrap code to pull them from there.

Comment 1

[Chris Cooper [:coop] (he/him)]

I copied the release scripts over into hg.m.o/build/tools this morning.

changeset:   6:ca4c49d7d347

Working on the Bootstrap patch now.

Comment 2

[Chris Cooper [:coop] (he/him)]

I've re-imported the release scripts with CVS history.

changeset:   91:1e3adb91ad78

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Use hg version of l10nverify script

* added an hgUpdate() method which can be called automatically from hgClone() if a tag is specified
* added hgToolsTag to the configs
* added https:// to the front of the hgToolsRepo for Thunderbird to match the Firefox configs

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 361947 [details] [diff] [review]
Use hg version of l10nverify script

>? Bootstrap.kpf
>Index: Bootstrap/Step.pm
>===================================================================
>RCS file: /cvsroot/mozilla/tools/release/Bootstrap/Step.pm,v
>retrieving revision 1.21
>diff -u -p -r1.21 Step.pm
>--- Bootstrap/Step.pm	29 Jan 2009 22:57:21 -0000	1.21
>+++ Bootstrap/Step.pm	12 Feb 2009 06:32:08 -0000
>@@ -307,6 +307,41 @@ sub HgClone {
>       cmdArgs => ['clone', $repo],
>       dir => $workDir
>     );
>+ 
>+    if (exists($args{'tag'}) and

For consistency, please process this argument to $tag at the top of function with the other args.


>+    if (!exists($args{'tag'}) or
>+        $args{'tag'} =~ /^default$/i or
>+        $args{'tag'} =~ /^tip$/i) {

tip != default, actually. If the latest commit is on a different branch it will be tip. I don't imagine we'll have branches in this repository, but I think you should pull this check out, anyways.


This looks fine otherwise. r=bhearsum with those nits addressed.

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 361947 [details] [diff] [review]
Use hg version of l10nverify script

Nits fixed.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

I committed a follow up to this, adding "hgToolsTag      = default" to 
  fx-moz18-bootstrap.cfg
  fx-moz18-staging-bootstrap.cfg
  tb-moz18-bootstrap.cfg
  tb-moz18-staging-bootstrap.cfg

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #2)
> I've re-imported the release scripts with CVS history.
> 
> changeset:   91:1e3adb91ad78

Something must have gone wrong with this. Examples, the big jump from 3.0rc3 and 3.0.6
  http://hg.mozilla.org/build/tools/file/tip/release/updates/moz19-firefox-win32.cfg
and missing 2.0.0.16/17/18 in 
 http://hg.mozilla.org/build/tools/file/tip/release/updates/moz18-thunderbird-win32.cfg

Could you take another look Chris, or point me to the script that's used to import history from CVS ? I'll need it for Tb2.0.0.21 and we should probably retest 3.0.7 before it's released.

Comment 8

[Chris Cooper [:coop] (he/him)]

Attachment: Replace missing product versions from update configs (hg)

These versions got lost in the CVS->hg import.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 365289 [details] [diff] [review]
Replace missing product versions from update configs (hg)

>diff --git a/release/updates/moz18-firefox-linux.cfg b/release/updates/moz18-firefox-linux.cfg
> # 2.0.0.16 linux
> release="2.0.0.16" product="Firefox" platform="Linux_x86-gcc3" build_id="2008070204" locales="af ar be bg ca cs da de el en-GB en-US es-AR es-ES eu fi fr fy-NL ga-IE gu-IN he hu it ja ka ko ku lt mk mn nb-NO nl nn-NO pa-IN pl pt-BR pt-PT ro ru sk sl sv-SE tr uk zh-CN zh-TW" channel="betatest" from="/firefox/releases/2.0.0.16/linux-i686/%locale%/firefox-2.0.0.16.tar.gz" aus_server="https://aus2.mozilla.org" ftp_server="stage-old.mozilla.org/pub/mozilla.org" to="/firefox/nightly/2.0.0.17-candidates/build2/firefox-2.0.0.17.%locale%.linux-i686.tar.gz"

Please trim out everything after the from="... for release="2.0.0.16"

Changes to moz18-firefox-mac.cfg and moz18-firefox-win32.cfg are missing (need to add 2.0.0.17/18/19, and remove from=".. for 2.0.0.16)

>diff --git a/release/updates/moz18-thunderbird-mac.cfg b/release/updates/moz18-thunderbird-mac.cfg

Please trim out everything after the from="... for release="2.0.0.14"

>diff --git a/release/updates/moz18-thunderbird-win32.cfg b/release/updates/moz18-thunderbird-win32.cfg

Please trim out everything after the from="... for release="2.0.0.14"

>diff --git a/release/updates/moz19-firefox-win32.cfg b/release/updates/moz19-firefox-win32.cfg

Please trim out everything after the from="... for release="3.0.5"

Also need to bring over moz19-firefox-{win32,linux,mac}-major.cfg

Comment 10

[Chris Cooper [:coop] (he/him)]

Attachment: Replace missing product versions from update configs (hg), v2

Addresses Nick's comments.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 365338 [details] [diff] [review]
Replace missing product versions from update configs (hg), v2

Looks great, thanks coop.

Comment 12

[Chris Cooper [:coop] (he/him)]

Comment on attachment 365338 [details] [diff] [review]
Replace missing product versions from update configs (hg), v2

changeset: 234:646c76b7067e