451394 - Update l10n verification scripts to support both long filenames, and the releases/ directory structure

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris Cooper [:coop] (he/him)]

We need to update the l10n verification scripts to support both long filenames, and the releases/ directory structure.

Comment 1

[Chris Cooper [:coop] (he/him)]

Attachment: [checked in] Accept packages for verification in either the new or old directory/filename format

Notes:
* added Leopard support for unpacking, which will help give us more leeway in choosing slaves going forward;
* installdmg.ex is *almost* identical to the one developed for bug 438240, but the [lindex] is required to avoid the addition of curly braces by except. Maybe this is only an issue with filenames that contain spaces (new format);
* assumes that unpacking is always going to happen on a Mac. All commands used in the bash scripts *should* already be present on a Mac.

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 341617 [details] [diff] [review]
[checked in] Accept packages for verification in either the new or old directory/filename format

I should note that I've tested this on both 10.4 and 10.5(local) with both the old and new directory structure, and the contents of the diffs/ directory are identical in each case.

I should also note that there is no requirement for l10nverify that the old build and new build directories be in the same format (old vs new structure). Because we handle both naming formats now, and the builds are compared in sequence, there's no need to change the dir/filename structure prior to comparison.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 341617 [details] [diff] [review]
[checked in] Accept packages for verification in either the new or old directory/filename format

>+            if [ $is_leopard -eq 0 ]; then
>+		expect ../common/installdmg.ex "$pkg_file" > hdi.output || cleanup 1;
>+            else 
>+		echo "y" | PAGER="/bin/cat"  hdiutil attach -quiet -puppetstrings -noautoopen -mountpoint ./mnt "$pkg_file" > hdi.output
>+            fi

Out of curiosity, does the expect script work on 10.4? If so, we can just drop the if/else and use it.

>Index: l10n/verify_l10n.sh
>===================================================================
>+# Chomp trailing slash (can interfere with cut below)
>+release=`echo $release | sed -e 's|\/||'`

I think this would be better as..
sed -e 's|\/$||' to ensure we only strip from the end


r=bhearsum w/ the regex change, and possible dropping of the if/else

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 341617 [details] [diff] [review]
[checked in] Accept packages for verification in either the new or old directory/filename format

The expect script does also work on 10.4, so I've removed the Leopard check. The regexp has been fixed too.

Comment 5

[Chris Cooper [:coop] (he/him)]

Carried review forward for hg.

changeset:   10:eacd0e0cc208